Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 2857483002: Make DocumentMarker::AllMarkers() automatically track list of types (Closed)

Created:
3 years, 7 months ago by rlanday
Modified:
3 years, 7 months ago
Reviewers:
ojan, yosin_UTC9, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make DocumentMarker::AllMarkers() automatically track list of types Every time I try to add a new DocumentMarker, I get tripped up by this list needing to be updated. If we write it like this, it will automatically start including the new type, without any performance penalty. BUG=707867 Review-Url: https://codereview.chromium.org/2857483002 Cr-Commit-Position: refs/heads/master@{#470029} Committed: https://chromium.googlesource.com/chromium/src/+/b1bdbd3e0b51de1e6327e71d27e8b7425d475e04

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M third_party/WebKit/Source/core/editing/markers/DocumentMarker.h View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
rlanday
3 years, 7 months ago (2017-05-02 02:14:42 UTC) #2
Xiaocheng
lgtm All reviewers based in Japan are OOO... Please find someone else as owner.
3 years, 7 months ago (2017-05-02 18:07:18 UTC) #3
yosin_UTC9
lgtm
3 years, 7 months ago (2017-05-08 03:41:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2857483002/1
3 years, 7 months ago (2017-05-08 03:42:16 UTC) #8
commit-bot: I haz the power
All required reviewers (with asterisk prefixes) have not yet approved this CL. No L-G-T-M from ...
3 years, 7 months ago (2017-05-08 03:42:17 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2857483002/1
3 years, 7 months ago (2017-05-08 15:12:44 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-05-08 17:22:23 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b1bdbd3e0b51de1e6327e71d27e8...

Powered by Google App Engine
This is Rietveld 408576698