Use the task scheduler in the USB service on macOS and Windows

Use the task scheduler in the USB service on macOS and Windows

This updates the libusb-based USB service to use the task scheduler
which means it will be enabled on macOS and Windows. The new Windows
USB service will be updated next.

By executing these tasks on a sequence with the CONTINUE_ON_SHUTDOWN
trait a device or driver bug that causes a request to lock up should
not prevent Chrome from shutting down.

BUG=652416, 703585
Review-Url: https://codereview.chromium.org/2857473002
Cr-Commit-Position: refs/heads/master@{#468967}
Committed: https://chromium.googlesource.com/chromium/src/+/402c8ae126b3f215c11c3845637542db2a68ccc5

[Reilly Grant (use Gerrit), 2017-05-02 01:49:36]

reillyg@chromium.org changed reviewers:
+ robliao@chromium.org

[Reilly Grant (use Gerrit), 2017-05-02 01:49:36]

Please take a look. Same idea, different OS.

[robliao, 2017-05-02 14:32:59]

Some questions.

https://codereview.chromium.org/2857473002/diff/1/device/usb/usb_device_handl...
File device/usb/usb_device_handle_impl.cc (right):

https://codereview.chromium.org/2857473002/diff/1/device/usb/usb_device_handl...
device/usb/usb_device_handle_impl.cc:152: int interface_number() const { return
interface_number_; }
Should these accessors also be DCHECK'ing the sequence?

https://codereview.chromium.org/2857473002/diff/1/device/usb/usb_device_impl.cc
File device/usb/usb_device_impl.cc (right):

https://codereview.chromium.org/2857473002/diff/1/device/usb/usb_device_impl....
device/usb/usb_device_impl.cc:106: PlatformUsbDeviceHandle handle;
Optional: You can do a base::ThreadRestrictions::AssertIOAllowed() here.

https://codereview.chromium.org/2857473002/diff/1/device/usb/usb_service_impl.cc
File device/usb/usb_service_impl.cc (right):

https://codereview.chromium.org/2857473002/diff/1/device/usb/usb_service_impl...
device/usb/usb_service_impl.cc:226: base::PostTaskWithTraits(
Calls to this API are done in parallel. If this task needs to run before the the
one below, it may be more robust to have a sequenced blocking task runner here
(or if RefreshDevices is guaranteed to not be called before this is complete,
then it's all good here).

[Reilly Grant (use Gerrit), 2017-05-02 23:39:24]

Add AssertIOAllowed

[Reilly Grant (use Gerrit), 2017-05-02 23:41:33]

The CQ bit was checked by reillyg@chromium.org to run a CQ dry run

[Reilly Grant (use Gerrit), 2017-05-02 23:41:44]

https://codereview.chromium.org/2857473002/diff/1/device/usb/usb_device_handl...
File device/usb/usb_device_handle_impl.cc (right):

https://codereview.chromium.org/2857473002/diff/1/device/usb/usb_device_handl...
device/usb/usb_device_handle_impl.cc:152: int interface_number() const { return
interface_number_; }
On 2017/05/02 14:32:59, robliao wrote:
> Should these accessors also be DCHECK'ing the sequence?

DCHECKing in inline accessors is frowned upon. The important bit is that the
destructor is called on the correct thread as that is the method that does real
work.

https://codereview.chromium.org/2857473002/diff/1/device/usb/usb_device_impl.cc
File device/usb/usb_device_impl.cc (right):

https://codereview.chromium.org/2857473002/diff/1/device/usb/usb_device_impl....
device/usb/usb_device_impl.cc:106: PlatformUsbDeviceHandle handle;
On 2017/05/02 14:32:59, robliao wrote:
> Optional: You can do a base::ThreadRestrictions::AssertIOAllowed() here.

Done.

https://codereview.chromium.org/2857473002/diff/1/device/usb/usb_service_impl.cc
File device/usb/usb_service_impl.cc (right):

https://codereview.chromium.org/2857473002/diff/1/device/usb/usb_service_impl...
device/usb/usb_service_impl.cc:226: base::PostTaskWithTraits(
On 2017/05/02 14:32:59, robliao wrote:
> Calls to this API are done in parallel. If this task needs to run before the
the
> one below, it may be more robust to have a sequenced blocking task runner here
> (or if RefreshDevices is guaranteed to not be called before this is complete,
> then it's all good here).

That's fine. RefreshDevices is guaranteed not to post its task until this task
is done.

[commit-bot: I haz the power, 2017-05-02 23:42:12]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 01:37:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-03 01:37:59]

Dry run: This issue passed the CQ dry run.

[robliao, 2017-05-03 14:05:50]

Task usage lgtm.

[Reilly Grant (use Gerrit), 2017-05-03 14:39:26]

The CQ bit was checked by reillyg@chromium.org

[commit-bot: I haz the power, 2017-05-03 14:39:43]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 14:45:05]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493822366129940,
"parent_rev": "0b33b3200cfccc6453b9b7c5e29600369dac0f5a", "commit_rev":
"402c8ae126b3f215c11c3845637542db2a68ccc5"}

[commit-bot: I haz the power, 2017-05-03 14:45:15]

Description was changed from

==========
Use the task scheduler in the USB service on macOS and Windows

This updates the libusb-based USB service to use the task scheduler
which means it will be enabled on macOS and Windows. The new Windows
USB service will be updated next.

By executing these tasks on a sequence with the CONTINUE_ON_SHUTDOWN
trait a device or driver bug that causes a request to lock up should
not prevent Chrome from shutting down.

BUG=652416,703585
==========

to

==========
Use the task scheduler in the USB service on macOS and Windows

This updates the libusb-based USB service to use the task scheduler
which means it will be enabled on macOS and Windows. The new Windows
USB service will be updated next.

By executing these tasks on a sequence with the CONTINUE_ON_SHUTDOWN
trait a device or driver bug that causes a request to lock up should
not prevent Chrome from shutting down.

BUG=652416,703585

Review-Url: https://codereview.chromium.org/2857473002
Cr-Commit-Position: refs/heads/master@{#468967}
Committed:
https://chromium.googlesource.com/chromium/src/+/402c8ae126b3f215c11c38456375...
==========

[commit-bot: I haz the power, 2017-05-03 14:45:16]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/402c8ae126b3f215c11c38456375...