Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 2857443002: Finally fix on_error_test hang. (Closed)

Created:
3 years, 7 months ago by M-A Ruel
Modified:
3 years, 7 months ago
Reviewers:
Vadim Sh.
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Finally fix on_error_test hang. This is due to recent python version which verifies certificate validity. R=vadimsh@chromium.org BUG=695897 Review-Url: https://codereview.chromium.org/2857443002 Committed: https://github.com/luci/luci-py/commit/66d820032ebcc6a8ff324f5a6e4dca69a135bb2f

Patch Set 1 #

Patch Set 2 : Add default None value for getattr() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M client/tests/on_error_test.py View 1 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
M-A Ruel
3 years, 7 months ago (2017-05-02 01:06:05 UTC) #1
Vadim Sh.
lgtm if it works
3 years, 7 months ago (2017-05-02 18:00:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2857443002/1
3 years, 7 months ago (2017-05-02 18:20:22 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: Luci-py Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/35e3381a5eea4410)
3 years, 7 months ago (2017-05-02 18:25:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2857443002/20001
3 years, 7 months ago (2017-05-02 18:27:32 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 18:30:28 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-py/commit/66d820032ebcc6a8ff324f5a6e4dca69a135bb2f

Powered by Google App Engine
This is Rietveld 408576698