Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Issue 2857413002: htmlTag was missing from the list of stringAttributes for an automationNode (Closed)

Created:
3 years, 7 months ago by aleventhal
Modified:
3 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

htmlTag was missing from the list of stringAttributes for an automationNode BUG=718448 Review-Url: https://codereview.chromium.org/2857413002 Cr-Commit-Position: refs/heads/master@{#469501} Committed: https://chromium.googlesource.com/chromium/src/+/154f59583bb9ef7a52c5a749cb201c1f4d1107d0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M chrome/renderer/resources/extensions/automation/automation_node.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/automation/sites/attributes.html View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/automation/tests/tabs/attributes.js View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
aleventhal
3 years, 7 months ago (2017-05-04 16:17:19 UTC) #5
dmazzoni
lgtm
3 years, 7 months ago (2017-05-04 16:19:36 UTC) #6
aleventhal
3 years, 7 months ago (2017-05-04 16:45:44 UTC) #9
aboxhall
lgtm
3 years, 7 months ago (2017-05-04 22:40:26 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2857413002/1
3 years, 7 months ago (2017-05-04 22:44:40 UTC) #14
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 22:54:43 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/154f59583bb9ef7a52c5a749cb20...

Powered by Google App Engine
This is Rietveld 408576698