Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2857403002: Move trace event emitting calls to outside of test run time measurement (Closed)

Created:
3 years, 7 months ago by nednguyen
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move trace event emitting calls to outside of test run time measurement This removes the overhead of emitting trace events from run time measurement. On tests like Layout/character_fallback_aat.html, this reduces the test's duration 3x (0.015ms --> 0.005ms) BUG=716394, 701059 TBR=wangxianzhu@chromium.org Review-Url: https://codereview.chromium.org/2857403002 Cr-Commit-Position: refs/heads/master@{#469329} Committed: https://chromium.googlesource.com/chromium/src/+/5f01ea694ea9f77fe1424d8fefac44a28e3d297e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/PerformanceTests/resources/runner.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2857403002/1
3 years, 7 months ago (2017-05-04 13:30:16 UTC) #4
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 14:45:07 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5f01ea694ea9f77fe1424d8fefac...

Powered by Google App Engine
This is Rietveld 408576698