Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2857393006: Fix RunLoopTest.DisallowWaitingDeathTest for official builds. (Closed)

Created:
3 years, 7 months ago by gab
Modified:
3 years, 7 months ago
Reviewers:
danakj
CC:
chromium-reviews, danakj+watch_chromium.org, vmpstr+watch_chromium.org, mfomitchev
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix RunLoopTest.DisallowWaitingDeathTest for official builds. Official builds eat the error string of the CHECKs. BUG=703346 TBR=danakj@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2857393006 Cr-Commit-Position: refs/heads/master@{#469754} Committed: https://chromium.googlesource.com/chromium/src/+/968d9ebc4d22158616e9f55d01313f0973d13fea

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M base/run_loop_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (6 generated)
gab
TBR dana to fix official builders. Note to self: would be nice to have EXPECT_CHECK_DEATH ...
3 years, 7 months ago (2017-05-05 19:16:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2857393006/1
3 years, 7 months ago (2017-05-05 19:17:51 UTC) #6
danakj
LGTM
3 years, 7 months ago (2017-05-05 19:19:51 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-05-05 19:24:31 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/968d9ebc4d22158616e9f55d0131...

Powered by Google App Engine
This is Rietveld 408576698