Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2857393003: Adding to a closed sink throws.

Created:
3 years, 7 months ago by floitsch
Modified:
3 years, 7 months ago
Reviewers:
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Adding to a closed sink throws. As part of this CL reverts https://codereview.chromium.org/20036002. Fixes #29554 BUG= http://dartbug.com/29554

Patch Set 1 #

Patch Set 2 : Merge #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -41 lines) Patch
M CHANGELOG.md View 1 2 chunks +7 lines, -1 line 0 comments Download
M sdk/lib/async/stream_transformers.dart View 1 2 2 chunks +2 lines, -10 lines 0 comments Download
M sdk/lib/io/io_sink.dart View 1 1 chunk +2 lines, -18 lines 0 comments Download
M tests/standalone/io/file_test.dart View 1 chunk +3 lines, -1 line 0 comments Download
M tests/standalone/io/http_10_test.dart View 1 chunk +3 lines, -1 line 0 comments Download
M tests/standalone/io/http_content_length_test.dart View 3 chunks +9 lines, -3 lines 0 comments Download
M tests/standalone/io/socket_exception_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M tests/standalone/io/socket_upgrade_to_secure_test.dart View 4 chunks +12 lines, -4 lines 0 comments Download

Messages

Total messages: 1 (1 generated)
floitsch
3 years, 7 months ago (2017-05-04 14:21:05 UTC) #1 
Description was changed from

==========
Adding to a closed sink throws.

Fixes #29554
BUG= http://dartbug.com/29554
==========

to

==========
Adding to a closed sink throws.

As part of this CL reverts https://codereview.chromium.org/20036002.

Fixes #29554
BUG= http://dartbug.com/29554
==========

Powered by Google App Engine
This is Rietveld 408576698