Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 20036002: Don't throw exceptions when adding to a IOSink(StreamSink) after close. (Closed)

Created:
7 years, 5 months ago by Anders Johnsen
Modified:
7 years, 5 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, kustermann
Visibility:
Public.

Description

Don't throw exceptions when adding to a IOSink(StreamSink) after close. As the IOSink can be closed from the consumer, it leads to unexpected exceptions. BUG=http://code.google.com/p/dart/issues/detail?id=11952 R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=25337

Patch Set 1 #

Patch Set 2 : Document the behaviour. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M sdk/lib/io/io_sink.dart View 1 2 chunks +5 lines, -1 line 0 comments Download
M tests/standalone/io/file_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/http_10_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M tests/standalone/io/http_content_length_test.dart View 3 chunks +3 lines, -6 lines 0 comments Download
M tests/standalone/io/socket_exception_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/socket_upgrade_to_secure_test.dart View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Anders Johnsen
7 years, 5 months ago (2013-07-23 09:13:15 UTC) #1
Søren Gjesse
lgtm However, we should document this behaviour. This documentation should mention closing from both the ...
7 years, 5 months ago (2013-07-23 10:16:09 UTC) #2
Anders Johnsen
PTAL
7 years, 5 months ago (2013-07-23 10:18:57 UTC) #3
Søren Gjesse
lgtm
7 years, 5 months ago (2013-07-23 10:33:36 UTC) #4
Anders Johnsen
7 years, 5 months ago (2013-07-23 10:37:55 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r25337 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698