Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2857363003: [DevTools] Move Audits 2.0 out of experiment, rename to Audits (Closed)

Created:
3 years, 7 months ago by dgozman
Modified:
3 years, 7 months ago
Reviewers:
Ilya Sherman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Move Audits 2.0 out of experiment, rename to Audits Previous audits panel goes by Legacy Audits, accessible through More tools menu. BUG=717085 Review-Url: https://codereview.chromium.org/2857363003 Cr-Commit-Position: refs/heads/master@{#469732} Committed: https://chromium.googlesource.com/chromium/src/+/717be5e78519e6531071e4491b951adc02f2fe38

Patch Set 1 #

Patch Set 2 : user metrics #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M third_party/WebKit/LayoutTests/inspector/user-metrics-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/audits/module.json View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/audits2/module.json View 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/help/features.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/host/UserMetrics.js View 1 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/Main.js View 2 chunks +0 lines, -3 lines 0 comments Download
M tools/metrics/histograms/enums.xml View 1 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
dgozman
Could you please take a look? Pavel - at devtools, Ilya - at histograms. Thank ...
3 years, 7 months ago (2017-05-04 19:48:16 UTC) #4
Ilya Sherman
enums.xml lgtm
3 years, 7 months ago (2017-05-04 19:51:24 UTC) #5
pfeldman
lgtm
3 years, 7 months ago (2017-05-04 22:26:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2857363003/20001
3 years, 7 months ago (2017-05-05 17:30:00 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-05 18:35:57 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/717be5e78519e6531071e4491b95...

Powered by Google App Engine
This is Rietveld 408576698