Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2857353002: Convert Spellcheck host MessageFilter IPC to mojo (Closed)

Created:
3 years, 7 months ago by Noel Gordon
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews, yzshen+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, timvolodine, abarth-chromium, Aaron Boodman, rlp+watch_chromium.org, rouslan+spell_chromium.org, groby+spellwatch_chromium.org, darin (slow to review)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert Spellcheck host MessageFilter IPC to mojo Moved to Gerrit code review https://chromium-review.googlesource.com/c/505648 BUG=714480

Patch Set 1 #

Patch Set 2 : Patch apply fix, build fix. #

Patch Set 3 : Fix OOPIF spellcheck test: must call the Mojo callback. #

Patch Set 4 : Fix SpellCheckHostImplTest. #

Patch Set 5 : Simplify SpellCheckHost unit test. #

Patch Set 6 : Add #ifdef guards to the ChromeSitePerProcessTest SpellCheckHost test. #

Patch Set 7 : Fix MultilingualSpellCheckTest.MultilingualSpellCheckWord. #

Patch Set 8 : Fix TestingSpellCheckProvider harness: create bind and message loop only if needed. #

Patch Set 9 : Reduce #ifdef in ChromeSitePerProcessTest, make dtor private. #

Patch Set 10 : Make messages_ private to TestingSpellCheckProvider harness. #

Patch Set 11 : Nope to #10, fix TestingSpellCheckProvider compile on OSX. #

Patch Set 12 : Server -> Service in SpellCheckHostImpl. #

Patch Set 13 : Move SpellCheckHost interface to spellcheck.mojo file. #

Patch Set 14 : Use MakeUnique for the MessageLoop in TestingSpellCheckProvider. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+701 lines, -551 lines) Patch
M chrome/browser/BUILD.gn View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 3 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/chrome_content_browser_manifest_overlay.json View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chrome_site_per_process_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 4 chunks +77 lines, -22 lines 0 comments Download
A chrome/browser/spellchecker/spellcheck_host_impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +77 lines, -0 lines 0 comments Download
A chrome/browser/spellchecker/spellcheck_host_impl.cc View 1 2 3 4 5 6 7 8 9 1 chunk +130 lines, -0 lines 0 comments Download
A chrome/browser/spellchecker/spellcheck_host_impl_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +89 lines, -0 lines 0 comments Download
D chrome/browser/spellchecker/spellcheck_message_filter.h View 1 chunk +0 lines, -72 lines 0 comments Download
D chrome/browser/spellchecker/spellcheck_message_filter.cc View 1 chunk +0 lines, -156 lines 0 comments Download
D chrome/browser/spellchecker/spellcheck_message_filter_unittest.cc View 1 chunk +0 lines, -148 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_service_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 11 6 chunks +114 lines, -28 lines 0 comments Download
M chrome/test/BUILD.gn View 1 1 chunk +4 lines, -1 line 0 comments Download
M components/spellcheck/common/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M components/spellcheck/common/spellcheck.mojom View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +25 lines, -0 lines 0 comments Download
A components/spellcheck/common/spellcheck.typemap View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +15 lines, -0 lines 0 comments Download
M components/spellcheck/common/spellcheck_messages.h View 3 chunks +1 line, -33 lines 0 comments Download
M components/spellcheck/renderer/hunspell_engine.cc View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +9 lines, -2 lines 0 comments Download
M components/spellcheck/renderer/spellcheck.h View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M components/spellcheck/renderer/spellcheck.cc View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M components/spellcheck/renderer/spellcheck_provider.h View 1 2 3 4 5 6 7 8 9 10 11 12 6 chunks +32 lines, -23 lines 0 comments Download
M components/spellcheck/renderer/spellcheck_provider.cc View 1 2 3 4 5 6 7 8 9 10 11 12 5 chunks +31 lines, -15 lines 0 comments Download
M components/spellcheck/renderer/spellcheck_provider_hunspell_unittest.cc View 1 2 3 4 5 6 7 8 9 5 chunks +9 lines, -1 line 0 comments Download
M components/spellcheck/renderer/spellcheck_provider_test.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 3 chunks +28 lines, -7 lines 0 comments Download
M components/spellcheck/renderer/spellcheck_provider_test.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +46 lines, -35 lines 0 comments Download
M components/typemaps.gni View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Issue 2828313002 Patch 200001

Messages

Total messages: 77 (77 generated)
Noel Gordon
The CQ bit was checked by noel@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-04 03:50:48 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2857353002/1
3 years, 7 months ago (2017-05-04 03:50:56 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-04 03:54:21 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/261981) chromium_presubmit on ...
3 years, 7 months ago (2017-05-04 03:54:22 UTC) #4
Noel Gordon
The CQ bit was checked by noel@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-04 15:59:02 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2857353002/20001
3 years, 7 months ago (2017-05-04 15:59:22 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-04 16:11:04 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/445254)
3 years, 7 months ago (2017-05-04 16:11:05 UTC) #8
Noel Gordon
Patchset #2 (id:20001) has been deleted
3 years, 7 months ago (2017-05-04 16:17:03 UTC) #9
Noel Gordon
The CQ bit was checked by noel@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-04 16:17:59 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2857353002/40001
3 years, 7 months ago (2017-05-04 16:18:28 UTC) #11
Noel Gordon
Patchset #2 (id:40001) has been deleted
3 years, 7 months ago (2017-05-04 16:30:36 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/445267)
3 years, 7 months ago (2017-05-04 16:31:28 UTC) #13
Noel Gordon
The CQ bit was checked by noel@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-04 16:35:00 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2857353002/60001
3 years, 7 months ago (2017-05-04 16:35:25 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-04 16:52:55 UTC) #16
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/410858)
3 years, 7 months ago (2017-05-04 16:52:56 UTC) #17
Noel Gordon
Patchset #2 (id:60001) has been deleted
3 years, 7 months ago (2017-05-04 16:56:25 UTC) #18
Noel Gordon
The CQ bit was checked by noel@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-04 16:57:39 UTC) #19
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2857353002/2
3 years, 7 months ago (2017-05-04 16:58:02 UTC) #20
Noel Gordon
Patchset #2 (id:2) has been deleted
3 years, 7 months ago (2017-05-04 17:11:31 UTC) #21
Noel Gordon
The CQ bit was checked by noel@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-04 17:12:52 UTC) #22
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2857353002/90001
3 years, 7 months ago (2017-05-04 17:13:19 UTC) #23
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-04 18:03:07 UTC) #24
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/418652)
3 years, 7 months ago (2017-05-04 18:03:09 UTC) #25
Noel Gordon
The CQ bit was checked by noel@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-04 23:47:02 UTC) #26
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2857353002/110001
3 years, 7 months ago (2017-05-04 23:47:46 UTC) #27
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-05 00:33:00 UTC) #28
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/445841)
3 years, 7 months ago (2017-05-05 00:33:01 UTC) #29
Noel Gordon
The CQ bit was checked by noel@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-05 07:20:27 UTC) #30
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2857353002/130001
3 years, 7 months ago (2017-05-05 07:20:39 UTC) #31
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-05 08:05:26 UTC) #32
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_tsan_rel_ng/builds/67588)
3 years, 7 months ago (2017-05-05 08:05:27 UTC) #33
Noel Gordon
The CQ bit was checked by noel@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-05 11:10:10 UTC) #34
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2857353002/150001
3 years, 7 months ago (2017-05-05 11:10:16 UTC) #35
Noel Gordon
Patchset #6 (id:170001) has been deleted
3 years, 7 months ago (2017-05-05 11:54:21 UTC) #36
Noel Gordon
The CQ bit was checked by noel@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-05 11:56:46 UTC) #37
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2857353002/190001
3 years, 7 months ago (2017-05-05 11:57:02 UTC) #38
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-05 12:36:25 UTC) #39
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/419324)
3 years, 7 months ago (2017-05-05 12:36:26 UTC) #40
Noel Gordon
The CQ bit was checked by noel@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-05 12:41:19 UTC) #41
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2857353002/210001
3 years, 7 months ago (2017-05-05 12:41:36 UTC) #42
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-05 13:19:27 UTC) #43
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/208293)
3 years, 7 months ago (2017-05-05 13:19:28 UTC) #44
Noel Gordon
The CQ bit was checked by noel@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-05 15:09:33 UTC) #45
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2857353002/230001
3 years, 7 months ago (2017-05-05 15:10:00 UTC) #46
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-05 15:23:35 UTC) #47
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/377415)
3 years, 7 months ago (2017-05-05 15:23:37 UTC) #48
Noel Gordon
The CQ bit was checked by noel@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-05 15:39:54 UTC) #49
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2857353002/250001
3 years, 7 months ago (2017-05-05 15:40:24 UTC) #50
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-05 17:01:15 UTC) #51
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
3 years, 7 months ago (2017-05-05 17:01:16 UTC) #52
Noel Gordon
The CQ bit was checked by noel@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-06 07:47:47 UTC) #53
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2857353002/270001
3 years, 7 months ago (2017-05-06 07:48:21 UTC) #54
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-06 08:03:44 UTC) #55
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/446902)
3 years, 7 months ago (2017-05-06 08:03:46 UTC) #56
Noel Gordon
The CQ bit was checked by noel@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-06 12:15:28 UTC) #57
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2857353002/310001
3 years, 7 months ago (2017-05-06 12:15:57 UTC) #58
Noel Gordon
Patchset #11 (id:290001) has been deleted
3 years, 7 months ago (2017-05-06 12:16:09 UTC) #59
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-06 13:24:01 UTC) #60
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
3 years, 7 months ago (2017-05-06 13:24:03 UTC) #61
Noel Gordon
The CQ bit was checked by noel@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-08 01:47:48 UTC) #62
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2857353002/330001
3 years, 7 months ago (2017-05-08 01:47:55 UTC) #63
Noel Gordon
The CQ bit was checked by noel@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-08 02:17:25 UTC) #64
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2857353002/350001
3 years, 7 months ago (2017-05-08 02:17:37 UTC) #65
Noel Gordon
Patchset #12 (id:330001) has been deleted
3 years, 7 months ago (2017-05-08 02:25:44 UTC) #66
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-08 03:38:48 UTC) #67
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/364599)
3 years, 7 months ago (2017-05-08 03:38:49 UTC) #68
Noel Gordon
The CQ bit was checked by noel@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-08 06:11:07 UTC) #69
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2857353002/370001
3 years, 7 months ago (2017-05-08 06:11:28 UTC) #70
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-08 08:08:30 UTC) #71
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
3 years, 7 months ago (2017-05-08 08:08:31 UTC) #72
Noel Gordon
The CQ bit was checked by noel@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-08 11:07:13 UTC) #73
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2857353002/390001
3 years, 7 months ago (2017-05-08 11:07:26 UTC) #74
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-08 12:15:48 UTC) #75
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
3 years, 7 months ago (2017-05-08 12:15:49 UTC) #76
Noel Gordon
3 years, 7 months ago (2017-05-15 02:42:53 UTC) #77 
Description was changed from

==========
Convert Spellcheck host MessageFilter IPC to mojo

BUG=714480
==========

to

==========
Convert Spellcheck host MessageFilter IPC to mojo

Moved to Gerrit code review
  https://chromium-review.googlesource.com/c/505648

BUG=714480
==========

Powered by Google App Engine
This is Rietveld 408576698