Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Unified Diff: components/spellcheck/renderer/spellcheck_provider_test.h

Issue 2857353002: Convert Spellcheck host MessageFilter IPC to mojo (Closed)
Patch Set: Use MakeUnique for the MessageLoop in TestingSpellCheckProvider. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/spellcheck/renderer/spellcheck_provider_test.h
diff --git a/components/spellcheck/renderer/spellcheck_provider_test.h b/components/spellcheck/renderer/spellcheck_provider_test.h
index 89a354e1662b9748e6605deb6e4f3ee5ad5b4d79..62efb281d793275483a15889063b05dc2649a6d0 100644
--- a/components/spellcheck/renderer/spellcheck_provider_test.h
+++ b/components/spellcheck/renderer/spellcheck_provider_test.h
@@ -5,19 +5,23 @@
#ifndef COMPONENTS_SPELLCHECK_RENDERER_SPELLCHECK_PROVIDER_TEST_H_
#define COMPONENTS_SPELLCHECK_RENDERER_SPELLCHECK_PROVIDER_TEST_H_
-#include <stddef.h>
-
+#include <memory>
#include <vector>
#include "base/strings/string16.h"
#include "components/spellcheck/renderer/spellcheck_provider.h"
+#include "mojo/public/cpp/bindings/binding.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/WebKit/public/platform/WebVector.h"
#include "third_party/WebKit/public/web/WebTextCheckingCompletion.h"
#include "third_party/WebKit/public/web/WebTextCheckingResult.h"
+namespace base {
+class MessageLoop;
+}
+
namespace IPC {
- class Message;
+class Message;
}
// A fake completion object for verification.
@@ -35,17 +39,20 @@ class FakeTextCheckingCompletion : public blink::WebTextCheckingCompletion {
};
// Faked test target, which stores sent message for verification.
-class TestingSpellCheckProvider : public SpellCheckProvider {
+class TestingSpellCheckProvider : public SpellCheckProvider,
+ public spellcheck::mojom::SpellCheckHost {
public:
TestingSpellCheckProvider();
// Takes ownership of |spellcheck|.
explicit TestingSpellCheckProvider(SpellCheck* spellcheck);
~TestingSpellCheckProvider() override;
+
+ void RequestTextChecking(const base::string16& text,
+ blink::WebTextCheckingCompletion* completion);
+
bool Send(IPC::Message* message) override;
- void OnCallSpellingService(int route_id,
- int identifier,
- const base::string16& text);
+ void OnCallSpellingService(const base::string16& text);
void ResetResult();
void SetLastResults(
@@ -57,6 +64,20 @@ class TestingSpellCheckProvider : public SpellCheckProvider {
base::string16 text_;
std::vector<std::unique_ptr<IPC::Message>> messages_;
size_t spelling_service_call_count_;
+
+ private:
+ // spellcheck::mojom::SpellCheckerHost:
+ void RequestDictionary() override;
+ void NotifyChecked(const base::string16& word, bool misspelled) override;
+ void CallSpellingService(
+ const base::string16& text,
+ const CallSpellingServiceCallback& callback) override;
+
+ // Message loop (if needed) to deliver the SpellCheckHost request flow.
+ std::unique_ptr<base::MessageLoop> loop_;
+
+ // Binding to receive the SpellCheckHost request flow.
+ mojo::Binding<spellcheck::mojom::SpellCheckHost> binding_;
};
// SpellCheckProvider test fixture.

Powered by Google App Engine
This is Rietveld 408576698