Fix flakiness in PushPullFIFOSmokeTest.SmokeTests/7

Fix flakiness in PushPullFIFOSmokeTest.SmokeTests/7

This sub-test often crashes because the test runner prematurely starts
tear-down process when the given test duration is up while there are
pending tasks in the thread task scheduler.

Remove the fixed test duration and wait for the actual task/thread to
be completed. Locally confirmed that the test runner waits until tasks
is completed.

BUG=718715
Review-Url: https://codereview.chromium.org/2857333006
Cr-Commit-Position: refs/heads/master@{#470101}
Committed: https://chromium.googlesource.com/chromium/src/+/c7b7263536e2151b952fe4f0884bad4e495da2e0

[hongchan, 2017-05-05 17:59:35]

hongchan@chromium.org changed reviewers:
+ olka@chromium.org, rtoy@chromium.org

[hongchan, 2017-05-05 17:59:35]

PTAL.

[hongchan, 2017-05-05 18:04:33]

The CQ bit was checked by hongchan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-05 18:05:10]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 19:14:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-05 19:14:34]

Dry run: This issue passed the CQ dry run.

[Raymond Toy, 2017-05-05 23:12:03]

lgtm

[o1ka, 2017-05-08 12:11:56]

lgtm if both lines in question can be (and are) removed.

https://codereview.chromium.org/2857333006/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/audio/PushPullFIFOMultithreadTest.cpp
(right):

https://codereview.chromium.org/2857333006/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/audio/PushPullFIFOMultithreadTest.cpp:54:
client_thread_.reset();
Why is it needed?

https://codereview.chromium.org/2857333006/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/audio/PushPullFIFOMultithreadTest.cpp:203: //
Also give a bit more time (10ms per iteration) to finish the tear-down
Not sure what tear down process do you mean?
Nothing will run  after both |done_event_|s are signaled, right?

[hongchan, 2017-05-08 18:18:29]

Patchset #2 (id:20001) has been deleted

[hongchan, 2017-05-08 18:18:56]

The CQ bit was checked by hongchan@chromium.org

[hongchan, 2017-05-08 18:18:56]

The patchset sent to the CQ was uploaded after l-g-t-m from olka@chromium.org,
rtoy@chromium.org
Link to the patchset: https://codereview.chromium.org/2857333006/#ps40001
(title: "Remove fortible test runner tear-down and use WaitableEvent")

[hongchan, 2017-05-08 18:19:33]

@olka

Thanks! I was able to remove them.

https://codereview.chromium.org/2857333006/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/audio/PushPullFIFOMultithreadTest.cpp
(right):

https://codereview.chromium.org/2857333006/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/audio/PushPullFIFOMultithreadTest.cpp:54:
client_thread_.reset();
On 2017/05/08 12:11:56, o1ka wrote:
> Why is it needed?

Removed.

https://codereview.chromium.org/2857333006/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/audio/PushPullFIFOMultithreadTest.cpp:203: //
Also give a bit more time (10ms per iteration) to finish the tear-down
On 2017/05/08 12:11:56, o1ka wrote:
> Not sure what tear down process do you mean?
> Nothing will run  after both |done_event_|s are signaled, right?

Done.

[commit-bot: I haz the power, 2017-05-08 18:19:49]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 20:15:40]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494267536107440,
"parent_rev": "5a367b9cf506209e6041299beac572a8348df154", "commit_rev":
"c7b7263536e2151b952fe4f0884bad4e495da2e0"}

[commit-bot: I haz the power, 2017-05-08 20:15:53]

Description was changed from

==========
Fix flakiness in PushPullFIFOSmokeTest.SmokeTests/7

This sub-test often crashes because the test runner prematurely starts
tear-down process when the given test duration is up while there are
pending tasks in the thread task scheduler.

Remove the fixed test duration and wait for the actual task/thread to
be completed. Locally confirmed that the test runner waits until tasks
is completed.

BUG=718715
==========

to

==========
Fix flakiness in PushPullFIFOSmokeTest.SmokeTests/7

This sub-test often crashes because the test runner prematurely starts
tear-down process when the given test duration is up while there are
pending tasks in the thread task scheduler.

Remove the fixed test duration and wait for the actual task/thread to
be completed. Locally confirmed that the test runner waits until tasks
is completed.

BUG=718715

Review-Url: https://codereview.chromium.org/2857333006
Cr-Commit-Position: refs/heads/master@{#470101}
Committed:
https://chromium.googlesource.com/chromium/src/+/c7b7263536e2151b952fe4f0884b...
==========

[commit-bot: I haz the power, 2017-05-08 20:15:54]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/c7b7263536e2151b952fe4f0884b...