Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 2857333005: [css-typed-om] make all attributes of CSSScale mutable. (Closed)

Created:
3 years, 7 months ago by Hwanseung Lee
Modified:
3 years, 7 months ago
Reviewers:
meade_UTC10
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis, rjwright
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[css-typed-om] make all attributes of CSSScale mutable. make all attributes of CSSScale mutable. https://drafts.css-houdini.org/css-typed-om-1/#cssscale https://github.com/w3c/css-houdini-drafts/issues/351 BUG=545318 Review-Url: https://codereview.chromium.org/2857333005 Cr-Commit-Position: refs/heads/master@{#469597} Committed: https://chromium.googlesource.com/chromium/src/+/9be38ee3cdb9d6423ef692d5ab66f7318b58c7bd

Patch Set 1 : [css-typed-om] make all attributes of CSSScale mutable. #

Patch Set 2 : [css-typed-om] make all attributes of CSSScale mutable. #

Messages

Total messages: 22 (18 generated)
Hwanseung Lee
PTAL, thank you.
3 years, 7 months ago (2017-05-04 23:58:53 UTC) #14
meade_UTC10
lgtm ccing rjwright as FYI Thanks!
3 years, 7 months ago (2017-05-05 00:41:19 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2857333005/40001
3 years, 7 months ago (2017-05-05 04:40:50 UTC) #19
commit-bot: I haz the power
3 years, 7 months ago (2017-05-05 04:45:45 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/9be38ee3cdb9d6423ef692d5ab66...

Powered by Google App Engine
This is Rietveld 408576698