Don't paint empty scroll corner

Don't paint empty scroll corner

The existing logic for checking whether the compositor has a scroll
corner layer is insufficient.  When the compositor runs
UpdateOverflowControlsLayers, it will delete its scroll corner layer
if the scroll corner isn't visible.  In this case, the paint code
should not try to paint the scroll corner.

The existing code causes a number of crashes in compositing tests
when this patch is applied:

https://codereview.chromium.org/2860433002

BUG=701575
R=pdr@chromium.org,chrishtr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2857333004
Cr-Commit-Position: refs/heads/master@{#469370}
Committed: https://chromium.googlesource.com/chromium/src/+/f240cb6e78c2d189ec6baabde91165b19b27a190

[szager1, 2017-05-04 14:51:16]

Description was changed from

==========
Don't paint empty scroll corner

The existing logic for checking whether the compositor has a scroll
corner layer is insufficient.  When the compositor runs
UpdateOverflowControlsLayers, it will delete its scroll corner layer
if the scroll corner isn't visible.  In this case, the paint code
should not try to paint the scroll corner.

The existing code causes a number of crashes in compositing tests
when this patch is applied:

https://codereview.chromium.org/2860433002

BUG=701575
R=pdr@chromium.org,chrishtr@chromium.org
==========

to

==========
Don't paint empty scroll corner

The existing logic for checking whether the compositor has a scroll
corner layer is insufficient.  When the compositor runs
UpdateOverflowControlsLayers, it will delete its scroll corner layer
if the scroll corner isn't visible.  In this case, the paint code
should not try to paint the scroll corner.

The existing code causes a number of crashes in compositing tests
when this patch is applied:

https://codereview.chromium.org/2860433002

BUG=701575
R=pdr@chromium.org,chrishtr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[szager1, 2017-05-04 14:51:21]

The CQ bit was checked by szager@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-04 14:51:37]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chrishtr, 2017-05-04 15:11:31]

lgtm

[commit-bot: I haz the power, 2017-05-04 16:26:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-04 16:26:07]

Dry run: This issue passed the CQ dry run.

[szager1, 2017-05-04 17:26:42]

The CQ bit was checked by szager@chromium.org

[commit-bot: I haz the power, 2017-05-04 17:27:18]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 17:33:30]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493918802760510, "parent_rev":
"dca98e1e37e61a0019ab182bdd7b18748575b6f1", "commit_rev":
"f240cb6e78c2d189ec6baabde91165b19b27a190"}

[commit-bot: I haz the power, 2017-05-04 17:34:14]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493918802760510, "parent_rev":
"dca98e1e37e61a0019ab182bdd7b18748575b6f1", "commit_rev":
"f240cb6e78c2d189ec6baabde91165b19b27a190"}

[commit-bot: I haz the power, 2017-05-04 17:34:16]

Description was changed from

==========
Don't paint empty scroll corner

The existing logic for checking whether the compositor has a scroll
corner layer is insufficient.  When the compositor runs
UpdateOverflowControlsLayers, it will delete its scroll corner layer
if the scroll corner isn't visible.  In this case, the paint code
should not try to paint the scroll corner.

The existing code causes a number of crashes in compositing tests
when this patch is applied:

https://codereview.chromium.org/2860433002

BUG=701575
R=pdr@chromium.org,chrishtr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Don't paint empty scroll corner

The existing logic for checking whether the compositor has a scroll
corner layer is insufficient.  When the compositor runs
UpdateOverflowControlsLayers, it will delete its scroll corner layer
if the scroll corner isn't visible.  In this case, the paint code
should not try to paint the scroll corner.

The existing code causes a number of crashes in compositing tests
when this patch is applied:

https://codereview.chromium.org/2860433002

BUG=701575
R=pdr@chromium.org,chrishtr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2857333004
Cr-Commit-Position: refs/heads/master@{#469370}
Committed:
https://chromium.googlesource.com/chromium/src/+/f240cb6e78c2d189ec6baabde911...
==========

[commit-bot: I haz the power, 2017-05-04 17:34:17]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f240cb6e78c2d189ec6baabde911...

[pdr., 2017-05-04 17:46:25]

LGTM