Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issue 2857323002: Enable IO when starting the license server (Closed)

Created:
3 years, 7 months ago by jrummell
Modified:
3 years, 7 months ago
Reviewers:
jam, xhwang
CC:
chromium-reviews, chfremer+watch_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable IO when starting the license server Due to recent changes to browser_tests, IO is not allowed. However the license server is just a Python script, so IO is necessary to start it. BUG=716663 TEST=affected browser_tests run locally NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2857323002 Cr-Commit-Position: refs/heads/master@{#469698} Committed: https://chromium.googlesource.com/chromium/src/+/90f8b2079c4dc288b432200cad216f7c81efc44a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M chrome/browser/media/encrypted_media_browsertest.cc View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
jrummell
PTAL. The fix is to allow IO when starting the license server, but the presubmit ...
3 years, 7 months ago (2017-05-03 23:16:57 UTC) #2
jam
lgtm
3 years, 7 months ago (2017-05-04 20:22:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2857323002/1
3 years, 7 months ago (2017-05-04 20:43:41 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/427721)
3 years, 7 months ago (2017-05-04 20:55:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2857323002/1
3 years, 7 months ago (2017-05-05 16:59:35 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-05 17:21:54 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/90f8b2079c4dc288b432200cad21...

Powered by Google App Engine
This is Rietveld 408576698