third_party/WebKit/Source/modules/notifications/NotificationData.cpp - Issue 2857303003: History API throws when serializing a SharedArrayBuffer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/notifications/NotificationData.cpp

Issue 2857303003: History API throws when serializing a SharedArrayBuffer (Closed)

Patch Set: use enum class instead of bool Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/modules/notifications/NotificationData.cpp

diff --git a/third_party/WebKit/Source/modules/notifications/NotificationData.cpp b/third_party/WebKit/Source/modules/notifications/NotificationData.cpp

index c0b8de3677254de684dc0a507164464866021540..5a788d92e292e80229e6a4cab34de4c9bd3c0a8e 100644

--- a/third_party/WebKit/Source/modules/notifications/NotificationData.cpp

+++ b/third_party/WebKit/Source/modules/notifications/NotificationData.cpp

@@ -87,7 +87,7 @@ WebNotificationData CreateWebNotificationData(

v8::Isolate* isolate = data.GetIsolate();

DCHECK(isolate->InContext());

SerializedScriptValue::SerializeOptions options;

- options.for_storage = true;

+ options.for_storage = SerializedScriptValue::SerializeForStorage::kYes;

RefPtr<SerializedScriptValue> serialized_script_value =

SerializedScriptValue::Serialize(isolate, data.V8Value(), options,

exception_state);

« third_party/WebKit/Source/bindings/scripts/v8_types.py ('K') | « third_party/WebKit/Source/modules/indexeddb/IDBObjectStore.cpp ('k') | no next file » | no next file with comments »