History API throws when serializing a SharedArrayBuffer

third_party/WebKit/Source/bindings/scripts/v8_types.py

Index: third_party/WebKit/Source/bindings/scripts/v8_types.py
diff --git a/third_party/WebKit/Source/bindings/scripts/v8_types.py b/third_party/WebKit/Source/bindings/scripts/v8_types.py
index e986398b797bc26638430afc634303c286e96e95..89f66c0b3deab6d6e08832ded30f26a0bebf4ca0 100644
--- a/third_party/WebKit/Source/bindings/scripts/v8_types.py
+++ b/third_party/WebKit/Source/bindings/scripts/v8_types.py
@@ -606,6 +606,11 @@ def v8_value_to_cpp_value(idl_type, extended_attributes, v8_value, variable_name
         elif 'Clamp' in extended_attributes:
             configuration = 'kClamp'
         arguments = ', '.join([v8_value, 'exceptionState', configuration])
+    elif base_idl_type == 'SerializedScriptValue':
+        arguments = ', '.join([
+            v8_value,
+            'SerializedScriptValue::SerializeOptions(SerializedScriptValue::SerializeForStorage::kYes)',

[jbroman, 2017/05/08 14:34:02]

It's not apparent why this v8_value_to_cpp_value should always serialize as if
going to disk. At the very least, this needs a justifying comment, but possibly
it should be done differently (see, e.g., haraken's comments).

[binji, 2017/05/09 01:07:08]

I needed to keep this code for the default case, but now it does kNotForStorage
by default (which it did before).

+            'exceptionState'])
     elif idl_type.v8_conversion_needs_exception_state:
         arguments = ', '.join([v8_value, 'exceptionState'])
     else: