third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializer.cpp - Issue 2857303003: History API throws when serializing a SharedArrayBuffer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializer.cpp

Issue 2857303003: History API throws when serializing a SharedArrayBuffer (Closed)

Patch Set: use enum class instead of bool Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.h ('K') | « third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.h ('k') | third_party/WebKit/Source/bindings/scripts/v8_types.py » ('j') | third_party/WebKit/Source/bindings/scripts/v8_types.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializer.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializer.cpp b/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializer.cpp

index dee9be55b981dc544ed993e2d6af79250b6d3903..f5a69e55c87723d88ce3a4490f6712ab33a4b36a 100644

--- a/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializer.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializer.cpp

@@ -52,7 +52,8 @@ V8ScriptValueSerializer::V8ScriptValueSerializer(

transferables_(options.transferables),

blob_info_array_(options.blob_info),

inline_wasm_(options.write_wasm_to_stream),

- for_storage_(options.for_storage) {}

+ for_storage_(options.for_storage ==

+ SerializedScriptValue::SerializeForStorage::kYes) {}

RefPtr<SerializedScriptValue> V8ScriptValueSerializer::Serialize(

v8::Local<v8::Value> value,