Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2857253002:
Add leak expectation for module WPT (Closed)
DescriptionAdd leak expectation for module WPT
This leak is caused by http://crrev.com/2781713003. I tried reverting manually, but it is a non-trivial revert, so I'm adding in a leak expectation for now.
TBR=hajimehoshi, hiroshige
BUG=718114
Review-Url: https://codereview.chromium.org/2857253002
Cr-Commit-Position: refs/heads/master@{#469130}
Committed: https://chromium.googlesource.com/chromium/src/+/cce51892785f3fcb3ec019197517c2c99bf38cc4
Patch Set 1 #
Messages
Total messages: 18 (12 generated)
adithyas@chromium.org changed reviewers: + hajimehoshi@chromium.org, hiroshige@chromium.org
The CQ bit was checked by adithyas@chromium.org
The CQ bit was unchecked by adithyas@chromium.org
Description was changed from ========== Add leak expectation for module WPT BUG=718114 ========== to ========== Add leak expectation for module WPT This leak is caused by http://crrev.com/2781713003. I tried reverting manually, but it is a non-trivial revert, so I'm adding in a leak expectation for now. BUG=718114 ==========
The CQ bit was checked by adithyas@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
Description was changed from ========== Add leak expectation for module WPT This leak is caused by http://crrev.com/2781713003. I tried reverting manually, but it is a non-trivial revert, so I'm adding in a leak expectation for now. BUG=718114 ========== to ========== Add leak expectation for module WPT This leak is caused by http://crrev.com/2781713003. I tried reverting manually, but it is a non-trivial revert, so I'm adding in a leak expectation for now. TBR=hajimehoshi, hiroshige BUG=718114 ==========
adithyas@chromium.org changed reviewers: - hajimehoshi@chromium.org, hiroshige@chromium.org
The CQ bit was checked by adithyas@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
hiroshige@chromium.org changed reviewers: + hiroshige@chromium.org
lgtm
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1493841333174960, "parent_rev":
"4ad1493ab09d85efdea49bbfb098e4c60856ee69", "commit_rev":
"cce51892785f3fcb3ec019197517c2c99bf38cc4"}
Message was sent while issue was closed.
Description was changed from ========== Add leak expectation for module WPT This leak is caused by http://crrev.com/2781713003. I tried reverting manually, but it is a non-trivial revert, so I'm adding in a leak expectation for now. TBR=hajimehoshi, hiroshige BUG=718114 ========== to ========== Add leak expectation for module WPT This leak is caused by http://crrev.com/2781713003. I tried reverting manually, but it is a non-trivial revert, so I'm adding in a leak expectation for now. TBR=hajimehoshi, hiroshige BUG=718114 Review-Url: https://codereview.chromium.org/2857253002 Cr-Commit-Position: refs/heads/master@{#469130} Committed: https://chromium.googlesource.com/chromium/src/+/cce51892785f3fcb3ec019197517... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/cce51892785f3fcb3ec019197517... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
