Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 2857213003: [heap] Fix RuntimeCallTimerScope usages (Closed)

Created:
3 years, 7 months ago by Michael Lippautz
Modified:
3 years, 7 months ago
Reviewers:
ulan, Camillo Bruni
CC:
Hannes Payer (out of office), v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Fix RuntimeCallTimerScope usages BUG=v8:6343 Review-Url: https://codereview.chromium.org/2857213003 Cr-Commit-Position: refs/heads/master@{#45077} Committed: https://chromium.googlesource.com/v8/v8/+/b00b2c256cfb41dbeab70fc7d8fa15f605c117be

Patch Set 1 #

Patch Set 2 : Fix existing runtime call stats scopes #

Patch Set 3 : Just fix timer scopes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M src/heap/heap.cc View 1 2 4 chunks +7 lines, -4 lines 0 comments Download
M src/heap/spaces.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
Michael Lippautz
PTAL I think this is a better approach that should also capture all the factory ...
3 years, 7 months ago (2017-05-04 06:20:20 UTC) #1
Michael Lippautz
And I just saw that we missed the actual stack variable for all our runtime ...
3 years, 7 months ago (2017-05-04 06:35:27 UTC) #4
Camillo Bruni
lgtm
3 years, 7 months ago (2017-05-04 08:00:22 UTC) #10
Michael Lippautz
fyi: I am just fixing the timer scope usages in this CL, so this can ...
3 years, 7 months ago (2017-05-04 08:27:17 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2857213003/40001
3 years, 7 months ago (2017-05-04 08:27:25 UTC) #15
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 08:58:04 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/b00b2c256cfb41dbeab70fc7d8fa15f605c...

Powered by Google App Engine
This is Rietveld 408576698