Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: tools/binary_size/libsupersize/models.py

Issue 2857153002: supersize: Tweak diff symbol matching for generated symbols (Closed)
Patch Set: review Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/binary_size/libsupersize/integration_test.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/binary_size/libsupersize/models.py
diff --git a/tools/binary_size/libsupersize/models.py b/tools/binary_size/libsupersize/models.py
index d9529f1798abcdde81c85bc22372208fd4c9b4df..22c8c6110742cadf47cdfab9f97f31e1da5ea6c0 100644
--- a/tools/binary_size/libsupersize/models.py
+++ b/tools/binary_size/libsupersize/models.py
@@ -57,13 +57,6 @@ FLAG_REL = 8
FLAG_REL_LOCAL = 16
-def _StripCloneSuffix(name):
- clone_idx = name.find(' [clone ')
- if clone_idx != -1:
- return name[:clone_idx]
- return name
-
-
class SizeInfo(object):
"""Represents all size information for a single binary.
@@ -178,17 +171,6 @@ class BaseSymbol(object):
# startup._GLOBAL__sub_I_page_allocator.cc
return self.name.endswith(']') and not self.name.endswith('[]')
- def _Key(self):
- """Returns a tuple that can be used to see if two Symbol are the same.
-
- Keys are not guaranteed to be unique within a SymbolGroup. For example, it
- is common to have multiple "** merge strings" symbols, which will have a
- common key."""
- stripped_full_name = self.full_name
- if stripped_full_name:
- stripped_full_name = _StripCloneSuffix(stripped_full_name)
- return (self.section_name, stripped_full_name or self.name)
-
class Symbol(BaseSymbol):
"""Represents a single symbol within a binary.
« no previous file with comments | « tools/binary_size/libsupersize/integration_test.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698