Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Unified Diff: tools/binary_size/libsupersize/integration_test.py

Issue 2857153002: supersize: Tweak diff symbol matching for generated symbols (Closed)
Patch Set: review Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/binary_size/libsupersize/diff.py ('k') | tools/binary_size/libsupersize/models.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/binary_size/libsupersize/integration_test.py
diff --git a/tools/binary_size/libsupersize/integration_test.py b/tools/binary_size/libsupersize/integration_test.py
index 6e27a2c8ec3499462caab45371241db1f3ec6dba..777a09cce3b49f1e532b5eda6fafd46756117bc9 100755
--- a/tools/binary_size/libsupersize/integration_test.py
+++ b/tools/binary_size/libsupersize/integration_test.py
@@ -236,6 +236,29 @@ class IntegrationTest(unittest.TestCase):
self.assertEquals(d.symbols.size, a1.size)
self.assertEquals(d.symbols.added_count, 3)
+ def test_Diff_Clustering(self):
+ size_info1 = self._CloneSizeInfo()
+ size_info2 = self._CloneSizeInfo()
+ S = '.text'
+ size_info1.symbols += [
+ models.Symbol(S, 11, name='.L__unnamed_1193', object_path='a'), # 1
+ models.Symbol(S, 22, name='.L__unnamed_1194', object_path='a'), # 2
+ models.Symbol(S, 33, name='.L__unnamed_1195', object_path='b'), # 3
+ models.Symbol(S, 44, name='.L__bar_195', object_path='b'), # 4
+ models.Symbol(S, 55, name='.L__bar_1195', object_path='b'), # 5
+ ]
+ size_info2.symbols += [
+ models.Symbol(S, 33, name='.L__unnamed_2195', object_path='b'), # 3
+ models.Symbol(S, 11, name='.L__unnamed_2194', object_path='a'), # 1
+ models.Symbol(S, 22, name='.L__unnamed_2193', object_path='a'), # 2
+ models.Symbol(S, 44, name='.L__bar_2195', object_path='b'), # 4
+ models.Symbol(S, 55, name='.L__bar_295', object_path='b'), # 5
+ ]
+ d = diff.Diff(size_info1, size_info2)
+ self.assertEquals(d.symbols.added_count, 0)
+ self.assertEquals(d.symbols.size, 0)
+
+
@_CompareWithGolden()
def test_FullDescription(self):
return describe.GenerateLines(self._CloneSizeInfo().Cluster(),
« no previous file with comments | « tools/binary_size/libsupersize/diff.py ('k') | tools/binary_size/libsupersize/models.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698