Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2857143005: Gather serialization-related code into a directory. (Closed)

Created:
3 years, 7 months ago by jbroman
Modified:
3 years, 7 months ago
Reviewers:
haraken
CC:
awdf+watch_chromium.org, blink-reviews, blink-reviews-bindings_chromium.org, blink-reviews-dom_chromium.org, blink-reviews-frames_chromium.org, blink-worker-reviews_chromium.org, chromium-reviews, cmumford, dglazkov+blink, eae+blinkwatch, falken+watch_chromium.org, fuzzing_chromium.org, horo+watch_chromium.org, jbroman+watch_chromium.org, jsbell+serviceworker_chromium.org, jsbell+idb_chromium.org, kinuko+watch, kinuko+worker_chromium.org, kinuko+serviceworker, michaeln, nhiroki, Peter Beverloo, rwlbuis, serviceworker-reviews, shimazu+worker_chromium.org, shimazu+serviceworker_chromium.org, sof, tzik
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Gather serialization-related code into a directory. Pure code movement. Review-Url: https://codereview.chromium.org/2857143005 Cr-Commit-Position: refs/heads/master@{#469539} Committed: https://chromium.googlesource.com/chromium/src/+/0f4c67a6a0ab2e4fc4b57d888ff5a007cee93700

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -1339 lines) Patch
M third_party/WebKit/Source/bindings/bindings.gni View 4 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/GeneratedCodeHelper.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/Source/bindings/core/v8/SerializationTag.h View 1 chunk +0 lines, -86 lines 0 comments Download
D third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.h View 1 chunk +0 lines, -243 lines 0 comments Download
D third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.cpp View 1 chunk +0 lines, -537 lines 0 comments Download
D third_party/WebKit/Source/bindings/core/v8/SerializedScriptValueFactory.h View 1 chunk +0 lines, -66 lines 0 comments Download
D third_party/WebKit/Source/bindings/core/v8/SerializedScriptValueFactory.cpp View 1 chunk +0 lines, -35 lines 0 comments Download
D third_party/WebKit/Source/bindings/core/v8/SerializedScriptValueTest.cpp View 1 chunk +0 lines, -170 lines 0 comments Download
D third_party/WebKit/Source/bindings/core/v8/Transferables.h View 1 chunk +0 lines, -44 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/custom/V8MessageEventCustom.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/custom/V8PopStateEventCustom.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
A + third_party/WebKit/Source/bindings/core/v8/serialization/SerializationTag.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/bindings/core/v8/serialization/SerializedScriptValue.h View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/bindings/core/v8/serialization/SerializedScriptValue.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
A + third_party/WebKit/Source/bindings/core/v8/serialization/SerializedScriptValueFactory.h View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/bindings/core/v8/serialization/SerializedScriptValueFactory.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/serialization/SerializedScriptValueFuzzer.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/bindings/core/v8/serialization/SerializedScriptValueTest.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
A + third_party/WebKit/Source/bindings/core/v8/serialization/Transferables.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueDeserializer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/ModuleBindingsInitializer.cpp View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/Source/bindings/modules/v8/SerializedScriptValueForModulesFactory.h View 1 chunk +0 lines, -36 lines 0 comments Download
D third_party/WebKit/Source/bindings/modules/v8/SerializedScriptValueForModulesFactory.cpp View 1 chunk +0 lines, -35 lines 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/V8BindingForModulesTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/bindings/modules/v8/serialization/SerializedScriptValueForModulesFactory.h View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/bindings/modules/v8/serialization/SerializedScriptValueForModulesFactory.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/v8.gni View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/scripts/v8_methods.py View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/scripts/v8_types.py View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/MessagePort.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/MessagePort.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/events/CustomEvent.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/events/MessageEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/PopStateEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/DOMWindow.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/History.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/HistoryItem.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/workers/DedicatedWorkerGlobalScope.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/broadcastchannel/BroadcastChannel.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/CompositorWorkerGlobalScope.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/credentialmanager/FederatedCredential.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/eventsource/EventSource.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBDatabase.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBKeyPathTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBObjectStore.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBObjectStore.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBVersionChangeEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/notifications/Notification.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/notifications/Notification.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/notifications/NotificationData.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClient.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClient.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/AssertMatchingEnums.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebDOMMessageEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebHistoryItem.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebSerializedScriptValue.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
jbroman
3 years, 7 months ago (2017-05-04 17:35:22 UTC) #4
haraken
LGTM
3 years, 7 months ago (2017-05-05 00:01:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2857143005/1
3 years, 7 months ago (2017-05-05 00:03:03 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-05 00:17:20 UTC) #12
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0f4c67a6a0ab2e4fc4b57d888ff5...

Powered by Google App Engine
This is Rietveld 408576698