Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2857143002:
Whitelist accessibilityPrivate APIs (Closed)
|
Created:
3 years, 7 months ago by Felix Ekblom Modified:
3 years, 7 months ago Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionWhitelist accessibilityPrivate APIs
BUG=717501
Review-Url: https://codereview.chromium.org/2857143002
Cr-Commit-Position: refs/heads/master@{#473700}
Committed: https://chromium.googlesource.com/chromium/src/+/ecf6be1dcf5f2fd0dd190742381d9dd52c0f3d26
Patch Set 1 #
Total comments: 4
Patch Set 2 : Use more fine grained permission to the touch start/stop components #Messages
Total messages: 26 (15 generated)
Description was changed from ========== Whitelist hotrod for accessibilityPrivate APIs BUG=717501 ========== to ========== Whitelist hotrod for accessibilityPrivate APIs BUG=717501 ==========
felixe@chromium.org changed reviewers: + dmazzoni@chromium.org
Description was changed from ========== Whitelist hotrod for accessibilityPrivate APIs BUG=717501 ========== to ========== Whitelist accessibilityPrivate APIs BUG=717501 ==========
dmazzoni@chromium.org changed reviewers: + rdevlin.cronin@chromium.org
lgtm +devlin for owners review This is for CFM devices, seems reasonable to me since their app is already whitelisted for several other private extension APIs. https://codereview.chromium.org/2857143002/diff/1/chrome/common/extensions/ap... File chrome/common/extensions/api/_permission_features.json (right): https://codereview.chromium.org/2857143002/diff/1/chrome/common/extensions/ap... chrome/common/extensions/api/_permission_features.json:26: "2FCBCE08B34CCA1728A85F1EFBD9A34DD2558B2E", Comment this one as ChromeVox https://codereview.chromium.org/2857143002/diff/1/chrome/common/extensions/ap... chrome/common/extensions/api/_permission_features.json:27: "E703483CEF33DEC18B4B6DD84B5C776FB9182BDB", // http://crbug.com/717501 Rather than a bug, comment it with the name of the app/extension.
(FYI, moving some basic questions to the bug)
The CQ bit was checked by felixe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by felixe@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
rdevlin.cronin@chromium.org changed reviewers: + lazyboy@chromium.org
+lazyboy since I'm OOO
https://codereview.chromium.org/2857143002/diff/1/chrome/common/extensions/ap... File chrome/common/extensions/api/_permission_features.json (right): https://codereview.chromium.org/2857143002/diff/1/chrome/common/extensions/ap... chrome/common/extensions/api/_permission_features.json:22: "accessibilityPrivate": { Add two separate entries for accessibilityPrivate.onTwoFingerTouchStart/Stop as suggested in the bug. I think you can specify "session_types": ["kiosk"] to limit those to kiosk only. https://codereview.chromium.org/2857143002/diff/1/chrome/common/extensions/ap... chrome/common/extensions/api/_permission_features.json:27: "E703483CEF33DEC18B4B6DD84B5C776FB9182BDB", // http://crbug.com/717501 On 2017/05/03 15:05:21, dmazzoni wrote: > Rather than a bug, comment it with the name of the app/extension. +1
Ping - we're getting close to the branch point, would be good to finish this.
lgtm unless anyone has any objections. The bug# would give us some context at least.
The CQ bit was checked by felixe@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dmazzoni@chromium.org Link to the patchset: https://codereview.chromium.org/2857143002/#ps20001 (title: "Use more fine grained permission to the touch start/stop components")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495485034787440,
"parent_rev": "2401662bf23c6bb0a9e666324cc9d72158d9cbbb", "commit_rev":
"ecf6be1dcf5f2fd0dd190742381d9dd52c0f3d26"}
Message was sent while issue was closed.
Description was changed from ========== Whitelist accessibilityPrivate APIs BUG=717501 ========== to ========== Whitelist accessibilityPrivate APIs BUG=717501 Review-Url: https://codereview.chromium.org/2857143002 Cr-Commit-Position: refs/heads/master@{#473700} Committed: https://chromium.googlesource.com/chromium/src/+/ecf6be1dcf5f2fd0dd190742381d... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/ecf6be1dcf5f2fd0dd190742381d... |
