[Remoting Client] Fix scaling bug in ViewMatrix

[Remoting Client] Fix scaling bug in ViewMatrix

I've forgot to scale the old offset before adding the offset adjustment :P
This CL fixes that bug and adds a test case to guard that pivot point remains
fixed after scaling.

BUG=714193
Review-Url: https://codereview.chromium.org/2857113002
Cr-Commit-Position: refs/heads/master@{#469047}
Committed: https://chromium.googlesource.com/chromium/src/+/5ba48720088b63559dd073eb28dfcbc9c99542a5

[Yuwei, 2017-05-03 01:35:37]

yuweih@chromium.org changed reviewers:
+ joedow@chromium.org

[Yuwei, 2017-05-03 01:35:38]

PTAL. Thanks!

[joedow, 2017-05-03 14:53:17]

lgtm

https://codereview.chromium.org/2857113002/diff/1/remoting/client/desktop_vie...
File remoting/client/desktop_viewport_unittest.cc (right):

https://codereview.chromium.org/2857113002/diff/1/remoting/client/desktop_vie...
remoting/client/desktop_viewport_unittest.cc:36: ViewMatrix
received_transformation_;
nit: typically methods are listed before member vars, can you move this down to
where it was previously?

[Yuwei, 2017-05-03 18:21:44]

Thanks!

https://codereview.chromium.org/2857113002/diff/1/remoting/client/desktop_vie...
File remoting/client/desktop_viewport_unittest.cc (right):

https://codereview.chromium.org/2857113002/diff/1/remoting/client/desktop_vie...
remoting/client/desktop_viewport_unittest.cc:36: ViewMatrix
received_transformation_;
On 2017/05/03 14:53:17, joedow wrote:
> nit: typically methods are listed before member vars, can you move this down
to
> where it was previously?

Done.

[Yuwei, 2017-05-03 18:21:50]

The CQ bit was checked by yuweih@chromium.org

[Yuwei, 2017-05-03 18:21:50]

The patchset sent to the CQ was uploaded after l-g-t-m from joedow@chromium.org
Link to the patchset: https://codereview.chromium.org/2857113002/#ps20001
(title: "Resolve Feedback")

[commit-bot: I haz the power, 2017-05-03 18:22:34]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 18:43:26]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493835710559120,
"parent_rev": "bb924e1897f5b4c67325dbfbdf2441e7f0686d53", "commit_rev":
"5ba48720088b63559dd073eb28dfcbc9c99542a5"}

[commit-bot: I haz the power, 2017-05-03 18:43:53]

Description was changed from

==========
[Remoting Client] Fix scaling bug in ViewMatrix

I've forgot to scale the old offset before adding the offset adjustment :P
This CL fixes that bug and adds a test case to guard that pivot point remains
fixed after scaling.

BUG=714193
==========

to

==========
[Remoting Client] Fix scaling bug in ViewMatrix

I've forgot to scale the old offset before adding the offset adjustment :P
This CL fixes that bug and adds a test case to guard that pivot point remains
fixed after scaling.

BUG=714193

Review-Url: https://codereview.chromium.org/2857113002
Cr-Commit-Position: refs/heads/master@{#469047}
Committed:
https://chromium.googlesource.com/chromium/src/+/5ba48720088b63559dd073eb28df...
==========

[commit-bot: I haz the power, 2017-05-03 18:43:54]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5ba48720088b63559dd073eb28df...