Fix behavior of GetOriginalNameFromHashedName

Fix behavior of GetOriginalNameFromHashedName

This is a minimal fix for issues with getUniformBlockIndex and
getTransformFeedbackVarying. Also removes unused Shader::GetMappedName.

This corrects the behavior of GetOriginalNameFromHashedName.
Previously, uniform block names were unmapped using "name_map", but
name_map was not restored upon load. Now, instead of name_map, the five
info maps (attrib, uniform, varying, interface block, output variable)
are queried serially in GetOriginalNameFromHashedName.

Unused code around name_map will be removed in a subsequent CL.

BUG=716018
TEST=https://github.com/KhronosGroup/WebGL/pull/2388
TEST=https://github.com/KhronosGroup/WebGL/pull/2389
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2857083002
Cr-Commit-Position: refs/heads/master@{#469209}
Committed: https://chromium.googlesource.com/chromium/src/+/830b099d96036c04006e844f36803bf6fc23443a

[Kai Ninomiya, 2017-05-02 23:53:28]

Description was changed from

==========
Fix behavior of GetOriginalNameFromHashedName

This is a minimal fix for issues with getUniformBlockIndex and
getTransformFeedbackVarying.

BUG=716018
TEST=https://github.com/KhronosGroup/WebGL/pull/2388
TEST=https://github.com/KhronosGroup/WebGL/pull/2389
==========

to

==========
Fix behavior of GetOriginalNameFromHashedName

This is a minimal fix for issues with getUniformBlockIndex and
getTransformFeedbackVarying.

BUG=716018
TEST=https://github.com/KhronosGroup/WebGL/pull/2388
TEST=https://github.com/KhronosGroup/WebGL/pull/2389
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Kai Ninomiya, 2017-05-02 23:57:41]

Description was changed from

==========
Fix behavior of GetOriginalNameFromHashedName

This is a minimal fix for issues with getUniformBlockIndex and
getTransformFeedbackVarying.

BUG=716018
TEST=https://github.com/KhronosGroup/WebGL/pull/2388
TEST=https://github.com/KhronosGroup/WebGL/pull/2389
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Fix behavior of GetOriginalNameFromHashedName

This is a minimal fix for issues with getUniformBlockIndex and
getTransformFeedbackVarying.

This corrects the behavior of GetOriginalNameFromHashedName.
Previously, uniform block names were unmapped using "name_map", but
name_map was not restored upon load. Now, instead of name_map, the five
info maps (attrib, uniform, varying, interface block, output variable)
are queried serially in GetOriginalNameFromHashedName.

Unused code around name_map will be removed in a subsequent CL.

BUG=716018
TEST=https://github.com/KhronosGroup/WebGL/pull/2388
TEST=https://github.com/KhronosGroup/WebGL/pull/2389
TEST=ShaderManagerTest.DoCompile
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Kai Ninomiya, 2017-05-03 00:09:09]

Description was changed from

==========
Fix behavior of GetOriginalNameFromHashedName

This is a minimal fix for issues with getUniformBlockIndex and
getTransformFeedbackVarying.

This corrects the behavior of GetOriginalNameFromHashedName.
Previously, uniform block names were unmapped using "name_map", but
name_map was not restored upon load. Now, instead of name_map, the five
info maps (attrib, uniform, varying, interface block, output variable)
are queried serially in GetOriginalNameFromHashedName.

Unused code around name_map will be removed in a subsequent CL.

BUG=716018
TEST=https://github.com/KhronosGroup/WebGL/pull/2388
TEST=https://github.com/KhronosGroup/WebGL/pull/2389
TEST=ShaderManagerTest.DoCompile
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Fix behavior of GetOriginalNameFromHashedName

This is a minimal fix for issues with getUniformBlockIndex and
getTransformFeedbackVarying.

This corrects the behavior of GetOriginalNameFromHashedName.
Previously, uniform block names were unmapped using "name_map", but
name_map was not restored upon load. Now, instead of name_map, the five
info maps (attrib, uniform, varying, interface block, output variable)
are queried serially in GetOriginalNameFromHashedName.

Unused code around name_map will be removed in a subsequent CL.

BUG=716018
TEST=https://github.com/KhronosGroup/WebGL/pull/2388
TEST=https://github.com/KhronosGroup/WebGL/pull/2389
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Kai Ninomiya, 2017-05-03 00:14:17]

kainino@chromium.org changed reviewers:
+ jbauman@chromium.org, kbr@chromium.org

[Kai Ninomiya, 2017-05-03 00:14:17]

kbr, jbauman: PTAL. This is the first half of this CL pair, the fix for the
original bug. I think it would be suitable for merge back to M59 if we wanted to
do that.

[Kai Ninomiya, 2017-05-03 18:13:12]

The CQ bit was checked by kainino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-03 18:14:04]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 19:43:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-03 19:43:03]

Dry run: This issue passed the CQ dry run.

[Kai Ninomiya, 2017-05-03 20:22:10]

Description was changed from

==========
Fix behavior of GetOriginalNameFromHashedName

This is a minimal fix for issues with getUniformBlockIndex and
getTransformFeedbackVarying.

This corrects the behavior of GetOriginalNameFromHashedName.
Previously, uniform block names were unmapped using "name_map", but
name_map was not restored upon load. Now, instead of name_map, the five
info maps (attrib, uniform, varying, interface block, output variable)
are queried serially in GetOriginalNameFromHashedName.

Unused code around name_map will be removed in a subsequent CL.

BUG=716018
TEST=https://github.com/KhronosGroup/WebGL/pull/2388
TEST=https://github.com/KhronosGroup/WebGL/pull/2389
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Fix behavior of GetOriginalNameFromHashedName

This is a minimal fix for issues with getUniformBlockIndex and
getTransformFeedbackVarying. Also removes unused Shader::GetMappedName.

This corrects the behavior of GetOriginalNameFromHashedName.
Previously, uniform block names were unmapped using "name_map", but
name_map was not restored upon load. Now, instead of name_map, the five
info maps (attrib, uniform, varying, interface block, output variable)
are queried serially in GetOriginalNameFromHashedName.

Unused code around name_map will be removed in a subsequent CL.

BUG=716018
TEST=https://github.com/KhronosGroup/WebGL/pull/2388
TEST=https://github.com/KhronosGroup/WebGL/pull/2389
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Ken Russell (switch to Gerrit), 2017-05-03 22:47:32]

Apologies for the delay reviewing. LGTM

CC'ing other reviewers.

[jbauman, 2017-05-03 22:52:00]

lgtm

[Kai Ninomiya, 2017-05-03 23:03:24]

The CQ bit was checked by kainino@chromium.org

[commit-bot: I haz the power, 2017-05-03 23:04:43]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 00:14:00]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493852604576210,
"parent_rev": "62b10acb8db135704af395a51ecf72d499944d76", "commit_rev":
"830b099d96036c04006e844f36803bf6fc23443a"}

[commit-bot: I haz the power, 2017-05-04 00:15:40]

Description was changed from

==========
Fix behavior of GetOriginalNameFromHashedName

This is a minimal fix for issues with getUniformBlockIndex and
getTransformFeedbackVarying. Also removes unused Shader::GetMappedName.

This corrects the behavior of GetOriginalNameFromHashedName.
Previously, uniform block names were unmapped using "name_map", but
name_map was not restored upon load. Now, instead of name_map, the five
info maps (attrib, uniform, varying, interface block, output variable)
are queried serially in GetOriginalNameFromHashedName.

Unused code around name_map will be removed in a subsequent CL.

BUG=716018
TEST=https://github.com/KhronosGroup/WebGL/pull/2388
TEST=https://github.com/KhronosGroup/WebGL/pull/2389
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Fix behavior of GetOriginalNameFromHashedName

This is a minimal fix for issues with getUniformBlockIndex and
getTransformFeedbackVarying. Also removes unused Shader::GetMappedName.

This corrects the behavior of GetOriginalNameFromHashedName.
Previously, uniform block names were unmapped using "name_map", but
name_map was not restored upon load. Now, instead of name_map, the five
info maps (attrib, uniform, varying, interface block, output variable)
are queried serially in GetOriginalNameFromHashedName.

Unused code around name_map will be removed in a subsequent CL.

BUG=716018
TEST=https://github.com/KhronosGroup/WebGL/pull/2388
TEST=https://github.com/KhronosGroup/WebGL/pull/2389
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2857083002
Cr-Commit-Position: refs/heads/master@{#469209}
Committed:
https://chromium.googlesource.com/chromium/src/+/830b099d96036c04006e844f3680...
==========

[commit-bot: I haz the power, 2017-05-04 00:15:42]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/830b099d96036c04006e844f3680...