Chromium Code Reviews| Index: chrome/browser/page_load_metrics/observers/resource_tracking_page_load_metrics_observer.h |
| diff --git a/chrome/browser/page_load_metrics/observers/resource_tracking_page_load_metrics_observer.h b/chrome/browser/page_load_metrics/observers/resource_tracking_page_load_metrics_observer.h |
| index 58e8d87861dccc8e9159af34fcad3797443fa0d7..a2dad35ba2eebc2ba24f768ab0476c6d308917db 100644 |
| --- a/chrome/browser/page_load_metrics/observers/resource_tracking_page_load_metrics_observer.h |
| +++ b/chrome/browser/page_load_metrics/observers/resource_tracking_page_load_metrics_observer.h |
| @@ -8,6 +8,12 @@ |
| #include <stdint.h> |
| #include "chrome/browser/page_load_metrics/page_load_metrics_observer.h" |
| +#include "components/offline_pages/core/background/offliner.h" |
| +#include "content/public/common/resource_type.h" |
| + |
| +namespace offline_pages { |
| +class ResourceTrackerObserver; |
| +} |
| namespace page_load_metrics { |
| @@ -29,19 +35,21 @@ class ResourceTrackingPageLoadMetricsObserver |
| void OnLoadedResource( |
| const ExtraRequestCompleteInfo& extra_request_complete_info) override; |
| - // For the specified type, get the count of requests started and completed. |
| - // TODO(petewil) Note that type is not used yet, code to use it is coming |
| - // soon. |
| - void GetCountsForTypeForTesting(const content::ResourceType type, |
| - int64_t* started_count, |
| - int64_t* completed_count); |
| + // Called when the page load commits, we return STOP_OBSERVING if the page is |
| + // not part of an offlining attempt. |
| + ObservePolicy OnCommit(content::NavigationHandle* navigation_handle) override; |
| private: |
| + void InformClient(const content::ResourceType type); |
| + |
| // TODO(petewil): Some way to keep track of what we've seen |
| // TODO(petewil): Some way to inform our keeper of aggregate results when they |
| // change. |
| int64_t started_count_; |
| int64_t completed_count_; |
| + // Unowned pointer to the ResourceTrackerObserver for this profile, it must be |
| + // kept valid by the caller for the lifetime of the PageLoadMetricsObserver. |
|
Dmitry Titov
2017/05/24 23:09:35
It is hard to say if "must be kept valid" requirem
|
| + offline_pages::Offliner* offliner_; |
| }; |
| } // namespace page_load_metrics |