Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1506)

Unified Diff: chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc

Issue 2857063002: Add a way to send the resource percentage signal to the RC. (Closed)
Patch Set: CR Feedback per Dimich, BMcQuade, and CSHarrison Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc
diff --git a/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc b/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc
index 87cb8c46e4e03162569518ce28d2ec39c9218c05..0de31064c0da3252563c0ae1f81147fe51d3e8c9 100644
--- a/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc
+++ b/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc
@@ -155,9 +155,16 @@ void PageLoadMetricsObserverTestHarness::SimulateStartedResource(
void PageLoadMetricsObserverTestHarness::SimulateLoadedResource(
const ExtraRequestCompleteInfo& info) {
+ content::ResourceType resource_type = content::RESOURCE_TYPE_SCRIPT;
+ // To be able to find the resource in GetTrackerOrNullForRequest,
+ // we depend on using something else instead of a MAIN_FRAME resource,
+ // so pretend this resource is the "SCRIPT" type for simulated loading.
+ if (info.resource_type != content::RESOURCE_TYPE_MAIN_FRAME)
jkarlin 2017/05/26 11:18:35 Changing the resource_type like this isn't okay he
+ resource_type = info.resource_type;
+
observer_->OnRequestComplete(
info.url, info.frame_tree_node_id, content::GlobalRequestID(),
- info.resource_type, info.was_cached,
+ resource_type, info.was_cached,
info.data_reduction_proxy_data
? info.data_reduction_proxy_data->DeepCopy()
: nullptr,

Powered by Google App Engine
This is Rietveld 408576698