Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Unified Diff: chrome/browser/page_load_metrics/observers/resource_tracking_page_load_metrics_observer.cc

Issue 2857063002: Add a way to send the resource percentage signal to the RC. (Closed)
Patch Set: cleanup Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/resource_tracking_page_load_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/observers/resource_tracking_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/resource_tracking_page_load_metrics_observer.cc
index 1f74a34c9256b916eb0faf7e96f060f6b7bea836..441c9ca9fa774adf3193769decb8677cb949cbd1 100644
--- a/chrome/browser/page_load_metrics/observers/resource_tracking_page_load_metrics_observer.cc
+++ b/chrome/browser/page_load_metrics/observers/resource_tracking_page_load_metrics_observer.cc
@@ -4,26 +4,89 @@
#include "chrome/browser/page_load_metrics/observers/resource_tracking_page_load_metrics_observer.h"
+#include "components/offline_pages/core/background/request_coordinator.h"
+#include "components/offline_pages/core/background/resource_data_type.h"
+#include "content/public/common/resource_type.h"
+
+namespace {
+offline_pages::ResourceDataType ConvertResourceTypeToResourceDataType(
+ content::ResourceType type) {
+ switch (type) {
+ case (content::RESOURCE_TYPE_MAIN_FRAME):
+ return offline_pages::ResourceDataType::TEXT_HTML;
+ case (content::RESOURCE_TYPE_SUB_FRAME):
+ return offline_pages::ResourceDataType::TEXT_HTML;
+ case (content::RESOURCE_TYPE_STYLESHEET):
+ return offline_pages::ResourceDataType::TEXT_CSS;
+ case (content::RESOURCE_TYPE_SCRIPT):
+ return offline_pages::ResourceDataType::TEXT_SCRIPT;
+ case (content::RESOURCE_TYPE_IMAGE):
+ return offline_pages::ResourceDataType::IMAGE;
+ case (content::RESOURCE_TYPE_FONT_RESOURCE):
+ return offline_pages::ResourceDataType::OTHER;
+ case (content::RESOURCE_TYPE_SUB_RESOURCE):
+ return offline_pages::ResourceDataType::OTHER;
+ case (content::RESOURCE_TYPE_OBJECT):
+ return offline_pages::ResourceDataType::OTHER;
+ case (content::RESOURCE_TYPE_MEDIA):
+ return offline_pages::ResourceDataType::MEDIA;
+ case (content::RESOURCE_TYPE_WORKER):
+ return offline_pages::ResourceDataType::OTHER;
+ case (content::RESOURCE_TYPE_SHARED_WORKER):
+ return offline_pages::ResourceDataType::OTHER;
+ case (content::RESOURCE_TYPE_PREFETCH):
+ return offline_pages::ResourceDataType::OTHER;
+ case (content::RESOURCE_TYPE_FAVICON):
+ return offline_pages::ResourceDataType::OTHER;
+ case (content::RESOURCE_TYPE_XHR):
+ return offline_pages::ResourceDataType::XHR;
+ case (content::RESOURCE_TYPE_PING):
+ return offline_pages::ResourceDataType::OTHER;
+ case (content::RESOURCE_TYPE_SERVICE_WORKER):
+ return offline_pages::ResourceDataType::OTHER;
+ case (content::RESOURCE_TYPE_CSP_REPORT):
+ return offline_pages::ResourceDataType::OTHER;
+ case (content::RESOURCE_TYPE_PLUGIN_RESOURCE):
+ return offline_pages::ResourceDataType::OTHER;
+ default:
+ return offline_pages::ResourceDataType::OTHER;
+ }
+}
+} // namespace
+
namespace page_load_metrics {
ResourceTrackingPageLoadMetricsObserver::
- ResourceTrackingPageLoadMetricsObserver()
- : started_count_(0), completed_count_(0) {}
+ ResourceTrackingPageLoadMetricsObserver(
+ offline_pages::ResourceTrackerObserver* request_coordinator)
+ : started_count_(0),
+ completed_count_(0),
+ request_coordinator_(request_coordinator) {}
ResourceTrackingPageLoadMetricsObserver::
~ResourceTrackingPageLoadMetricsObserver() {}
void ResourceTrackingPageLoadMetricsObserver::OnStartedResource(
const ExtraRequestStartInfo& extra_request_start_info) {
- // TODO(petewiL): Store this by type.
- ++started_count_;
+ // TODO(petewiL): Store this by type. Until we do, only look at images.
+ if (extra_request_start_info.resource_type == content::RESOURCE_TYPE_IMAGE) {
+ ++started_count_;
+ InformObservers(content::ResourceType::RESOURCE_TYPE_IMAGE, started_count_,
+ completed_count_);
+ }
}
void ResourceTrackingPageLoadMetricsObserver::OnLoadedResource(
const ExtraRequestCompleteInfo& extra_request_complete_info) {
// TODO(petewil): Check to see if the type of the request changed. If it did,
// update the old and new types for the started type. Then update by type for
- // the completed type.
- ++completed_count_;
+ // the completed type. Maybe we can just skip that, and count XHR as its own
+ // type.
+ if (extra_request_complete_info.resource_type ==
+ content::RESOURCE_TYPE_IMAGE) {
+ ++completed_count_;
+ InformObservers(content::ResourceType::RESOURCE_TYPE_IMAGE, started_count_,
+ completed_count_);
+ }
}
void ResourceTrackingPageLoadMetricsObserver::GetCountsForTypeForTesting(
@@ -36,4 +99,16 @@ void ResourceTrackingPageLoadMetricsObserver::GetCountsForTypeForTesting(
*completed_count = completed_count_;
}
+void ResourceTrackingPageLoadMetricsObserver::InformObservers(
+ const content::ResourceType type,
+ int64_t started_count,
+ int64_t completed_count) {
+ if (request_coordinator_) {
+ offline_pages::ResourceDataType converted_type =
+ ConvertResourceTypeToResourceDataType(type);
+ request_coordinator_->ObserveResourceTracking(converted_type, started_count,
+ completed_count);
+ }
+}
+
} // namespace page_load_metrics

Powered by Google App Engine
This is Rietveld 408576698