Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Unified Diff: chrome/browser/page_load_metrics/observers/resource_tracking_page_load_metrics_observer.h

Issue 2857063002: Add a way to send the resource percentage signal to the RC. (Closed)
Patch Set: cleanup Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/resource_tracking_page_load_metrics_observer.h
diff --git a/chrome/browser/page_load_metrics/observers/resource_tracking_page_load_metrics_observer.h b/chrome/browser/page_load_metrics/observers/resource_tracking_page_load_metrics_observer.h
index 58e8d87861dccc8e9159af34fcad3797443fa0d7..c18fcccc5c178f625b06e4d9c35073a1cf3f7b6e 100644
--- a/chrome/browser/page_load_metrics/observers/resource_tracking_page_load_metrics_observer.h
+++ b/chrome/browser/page_load_metrics/observers/resource_tracking_page_load_metrics_observer.h
@@ -8,13 +8,19 @@
#include <stdint.h>
#include "chrome/browser/page_load_metrics/page_load_metrics_observer.h"
+#include "content/public/common/resource_type.h"
+
+namespace offline_pages {
+class ResourceTrackerObserver;
+}
namespace page_load_metrics {
class ResourceTrackingPageLoadMetricsObserver
: public page_load_metrics::PageLoadMetricsObserver {
public:
- ResourceTrackingPageLoadMetricsObserver();
+ ResourceTrackingPageLoadMetricsObserver(
+ offline_pages::ResourceTrackerObserver* request_coordinator);
~ResourceTrackingPageLoadMetricsObserver() override;
// Called by the PageLoadMetrics framework when we start a new request, so we
@@ -29,7 +35,12 @@ class ResourceTrackingPageLoadMetricsObserver
void OnLoadedResource(
const ExtraRequestCompleteInfo& extra_request_complete_info) override;
- // For the specified type, get the count of requests started and completed.
+ void InformObservers(const content::ResourceType type,
RyanSturm 2017/05/10 15:55:53 private method?
Pete Williamson 2017/05/10 18:14:53 Done.
+ int64_t started_count,
+ int64_t completed_count);
+
+ // For the specified type, get the count of requests started and
+ // completed.
// TODO(petewil) Note that type is not used yet, code to use it is coming
// soon.
void GetCountsForTypeForTesting(const content::ResourceType type,
@@ -42,6 +53,9 @@ class ResourceTrackingPageLoadMetricsObserver
// change.
int64_t started_count_;
int64_t completed_count_;
+ // Unowned pointer to the request_coordinator_, it will be valid for the
+ // lifetime of the PageLoadMetricsObserver.
+ offline_pages::ResourceTrackerObserver* request_coordinator_;
};
} // namespace page_load_metrics

Powered by Google App Engine
This is Rietveld 408576698