PaymentHandler: Implement PaymentInstruments.clear().

PaymentHandler: Implement PaymentInstruments.clear().

The method to remove all stored payment instruments.

Related Spec Link:
  https://w3c.github.io/webpayments-payment-handler/#paymentinstruments-interface

BUG=661608
Review-Url: https://codereview.chromium.org/2856973002
Cr-Commit-Position: refs/heads/master@{#469628}
Committed: https://chromium.googlesource.com/chromium/src/+/af28f77a0befc157c0f229fc1b72d3601e5d1ba1

[zino, 2017-05-02 18:06:45]

jinho.bang@samsung.com changed reviewers:
+ rouslan@chromium.org, tsepez@chromium.org

[zino, 2017-05-02 18:06:45]

PTAL

[please use gerrit instead, 2017-05-02 20:08:12]

https://codereview.chromium.org/2856973002/diff/1/content/browser/payments/pa...
File content/browser/payments/payment_app_database.h (right):

https://codereview.chromium.org/2856973002/diff/1/content/browser/payments/pa...
content/browser/payments/payment_app_database.h:157: // ClearPaymentInstruments
callbacks
Wouldn't it be simpler to have one call with one callback instead of this
bouncing around?

https://codereview.chromium.org/2856973002/diff/1/content/browser/payments/pa...
File content/browser/payments/payment_manager_unittest.cc (right):

https://codereview.chromium.org/2856973002/diff/1/content/browser/payments/pa...
content/browser/payments/payment_manager_unittest.cc:134:
base::RunLoop().RunUntilIdle();
Why twice?

[Tom Sepez, 2017-05-02 22:05:55]

mojom itself LGTM

[zino, 2017-05-03 14:50:00]

https://codereview.chromium.org/2856973002/diff/1/content/browser/payments/pa...
File content/browser/payments/payment_app_database.h (right):

https://codereview.chromium.org/2856973002/diff/1/content/browser/payments/pa...
content/browser/payments/payment_app_database.h:157: // ClearPaymentInstruments
callbacks
On 2017/05/02 20:08:12, ಠ_ಠ wrote:
> Wouldn't it be simpler to have one call with one callback instead of this
> bouncing around?

Sorry, I don't understand your words fully.

If you'd like to call service_worker_context_->ClearRegistrationUserData()
without calling KeysOfPaymentInstruments, it's possible but we should add a new
API in service_worker directory.
But I thought that adding new APIs should be minimized if possible. (Moreover
this is not performance sensitive feature.)

https://codereview.chromium.org/2856973002/diff/1/content/browser/payments/pa...
File content/browser/payments/payment_manager_unittest.cc (right):

https://codereview.chromium.org/2856973002/diff/1/content/browser/payments/pa...
content/browser/payments/payment_manager_unittest.cc:134:
base::RunLoop().RunUntilIdle();
On 2017/05/02 20:08:12, ಠ_ಠ wrote:
> Why twice?

My mistake. :P

Thanks.

[please use gerrit instead, 2017-05-03 15:11:26]

lgtm

[zino, 2017-05-05 05:16:23]

The CQ bit was checked by jinho.bang@samsung.com

[zino, 2017-05-05 05:16:24]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
rouslan@chromium.org
Link to the patchset: https://codereview.chromium.org/2856973002/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2017-05-05 05:16:36]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 07:01:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-05 07:01:42]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[zino, 2017-05-05 10:29:35]

The CQ bit was checked by jinho.bang@samsung.com

[zino, 2017-05-05 10:29:35]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
rouslan@chromium.org
Link to the patchset: https://codereview.chromium.org/2856973002/#ps60001
(title: "PaymentHandler: Implement PaymentInstruments.clear().")

[commit-bot: I haz the power, 2017-05-05 10:29:49]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 12:22:14]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1493980175421570,
"parent_rev": "c0671c025e52b6072a6391c8e1cb8ffc4f13a24b", "commit_rev":
"af28f77a0befc157c0f229fc1b72d3601e5d1ba1"}

[commit-bot: I haz the power, 2017-05-05 12:22:25]

Description was changed from

==========
PaymentHandler: Implement PaymentInstruments.clear().

The method to remove all stored payment instruments.

Related Spec Link:
 
https://w3c.github.io/webpayments-payment-handler/#paymentinstruments-interface

BUG=661608
==========

to

==========
PaymentHandler: Implement PaymentInstruments.clear().

The method to remove all stored payment instruments.

Related Spec Link:
 
https://w3c.github.io/webpayments-payment-handler/#paymentinstruments-interface

BUG=661608

Review-Url: https://codereview.chromium.org/2856973002
Cr-Commit-Position: refs/heads/master@{#469628}
Committed:
https://chromium.googlesource.com/chromium/src/+/af28f77a0befc157c0f229fc1b72...
==========

[commit-bot: I haz the power, 2017-05-05 12:22:26]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/af28f77a0befc157c0f229fc1b72...