Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2856963003: Revert of Roll googletest to 1.8.0. (Closed)

Created:
3 years, 7 months ago by msramek
Modified:
3 years, 7 months ago
Reviewers:
rkc, Dirk Pranke, Nico, agl, pwnall
CC:
chromium-reviews, cbentzel+watch_chromium.org, vmpstr+watch_chromium.org, net-reviews_chromium.org, scheib+watch_chromium.org, ortuno+watch_chromium.org, mac-reviews_chromium.org, danakj+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Roll googletest to 1.8.0. (patchset #3 id:40001 of https://codereview.chromium.org/2852613002/ ) Reason for revert: Seems to have caused all content_browsertests on ChromiumOS to crash. https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/25582 I'll run the revert through trybots so that it doesn't break anything else. Original issue's description: > Roll googletest to 1.8.0. > > This is a re-land of http://crrev.com/2779193002 which was reverted due to > build errors on Mac. > > GoogleTest (gtest) and GoogleMock (gmock) are now hosted into the same > googletest repository. In order to cope with this, the googletest > repository is now sourced at third_party/googletest. > > The file/directory layout of Google Test is not yet considered stable. > To minimize disruption while Google Test stabilizes, Chromium code will > be insulated from third_party/googletest. > > * testing/gtest/include/gtest/ and testing/gmock/include/gmock have > been populated with headers that forward into the appropriate locations of > third_party/googletest > > * testing/BUILD.gn has been populated with the targets > //testing/gtest(:gtest_main) and //testing/gmock(:gmock_main), which > depend on the appropriate //third_party/googletest targets. > > All Chromium code should keep depending on the targets and headers > in testing/{gtest,gmock} for now. > > BUG=630705 > TESTED=ninja -C out/Default/ ced_unittests && ninja -C out/Default > TBR=rkc,dpranke,agl > > Review-Url: https://codereview.chromium.org/2852613002 > Cr-Commit-Position: refs/heads/master@{#468860} > Committed: https://chromium.googlesource.com/chromium/src/+/dbcef9bdc1edd32d62c6de0bd382cdc78ce385da TBR=dpranke@chromium.org,thakis@chromium.org,rkc@chromium.org,agl@chromium.org,pwnall@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=630705 Review-Url: https://codereview.chromium.org/2856963003 Cr-Commit-Position: refs/heads/master@{#468934} Committed: https://chromium.googlesource.com/chromium/src/+/a289707ca3726217915fb7cac34dcdeeaba1e3cc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -450 lines) Patch
M .gitignore View 1 chunk +2 lines, -0 lines 0 comments Download
M DEPS View 2 chunks +6 lines, -3 lines 0 comments Download
M base/gtest_prod_util.h View 1 chunk +1 line, -1 line 0 comments Download
M build/secondary/testing/gmock/BUILD.gn View 1 chunk +0 lines, -7 lines 0 comments Download
M build/secondary/testing/gtest/BUILD.gn View 1 chunk +0 lines, -7 lines 0 comments Download
M device/bluetooth/dbus/fake_bluetooth_media_endpoint_service_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/sequenced_socket_data_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D testing/gmock/BUILD.gn View 1 chunk +0 lines, -34 lines 0 comments Download
D testing/gmock/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D testing/gmock/include/gmock/gmock.h View 1 chunk +0 lines, -10 lines 0 comments Download
D testing/gmock/include/gmock/gmock-actions.h View 1 chunk +0 lines, -10 lines 0 comments Download
D testing/gmock/include/gmock/gmock-generated-function-mockers.h View 1 chunk +0 lines, -10 lines 0 comments Download
D testing/gmock/include/gmock/gmock-matchers.h View 1 chunk +0 lines, -10 lines 0 comments Download
A testing/gmock_custom/gmock/internal/custom/gmock-port.h View 1 chunk +27 lines, -0 lines 0 comments Download
D testing/gtest/BUILD.gn View 1 chunk +0 lines, -85 lines 0 comments Download
D testing/gtest/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D testing/gtest/empty.cc View 1 chunk +0 lines, -3 lines 0 comments Download
D testing/gtest/include/gtest/gtest.h View 1 chunk +0 lines, -10 lines 0 comments Download
D testing/gtest/include/gtest/gtest-death-test.h View 1 chunk +0 lines, -10 lines 0 comments Download
D testing/gtest/include/gtest/gtest-message.h View 1 chunk +0 lines, -10 lines 0 comments Download
D testing/gtest/include/gtest/gtest-param-test.h View 1 chunk +0 lines, -10 lines 0 comments Download
D testing/gtest/include/gtest/gtest-spi.h View 1 chunk +0 lines, -10 lines 0 comments Download
D testing/gtest/include/gtest/gtest_prod.h View 1 chunk +0 lines, -10 lines 0 comments Download
M testing/gtest_mac.h View 1 chunk +2 lines, -2 lines 0 comments Download
M testing/gtest_mac.mm View 1 chunk +3 lines, -3 lines 0 comments Download
M testing/gtest_mac_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M third_party/.gitignore View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/googletest/BUILD.gn View 1 chunk +0 lines, -150 lines 0 comments Download
D third_party/googletest/OWNERS View 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/googletest/README.chromium View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/googletest/gmock_custom/gmock/internal/custom/gmock-port.h View 1 chunk +0 lines, -25 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
msramek
Created Revert of Roll googletest to 1.8.0.
3 years, 7 months ago (2017-05-03 10:54:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2856963003/1
3 years, 7 months ago (2017-05-03 10:54:53 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 10:55:53 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a289707ca3726217915fb7cac34d...

Powered by Google App Engine
This is Rietveld 408576698