Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Issue 2856963002: Disable *.TrueTypeFont browser_test for Ozone CrOS. (Closed)

Created:
3 years, 7 months ago by kylechar
Modified:
3 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable *.TrueTypeFont browser_test for Ozone CrOS. These tests are already disabled in content_browsertests for Ozone CrOS. They aren't disabled in browser_tests, probably because it's not run as part of CQ. The implementation of TrueType font information is missing for Ozone because pango isn't compiled. This is probably the reason why the tests fail. BUG=619765 Review-Url: https://codereview.chromium.org/2856963002 Cr-Commit-Position: refs/heads/master@{#468961} Committed: https://chromium.googlesource.com/chromium/src/+/e3cfa1285898021bfe5bd4e62ddd94d0e97e6e93

Patch Set 1 #

Total comments: 2

Patch Set 2 : Change comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M chrome/test/ppapi/ppapi_browsertest.cc View 1 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
kylechar
3 years, 7 months ago (2017-05-02 18:08:32 UTC) #2
sky
LGTM
3 years, 7 months ago (2017-05-03 04:42:05 UTC) #3
sky
https://codereview.chromium.org/2856963002/diff/1/chrome/test/ppapi/ppapi_browsertest.cc File chrome/test/ppapi/ppapi_browsertest.cc (right): https://codereview.chromium.org/2856963002/diff/1/chrome/test/ppapi/ppapi_browsertest.cc#newcode1184 chrome/test/ppapi/ppapi_browsertest.cc:1184: // Doesn't work in GN CrOS ozone builds yet, ...
3 years, 7 months ago (2017-05-03 04:42:38 UTC) #4
kylechar
https://codereview.chromium.org/2856963002/diff/1/chrome/test/ppapi/ppapi_browsertest.cc File chrome/test/ppapi/ppapi_browsertest.cc (right): https://codereview.chromium.org/2856963002/diff/1/chrome/test/ppapi/ppapi_browsertest.cc#newcode1184 chrome/test/ppapi/ppapi_browsertest.cc:1184: // Doesn't work in GN CrOS ozone builds yet, ...
3 years, 7 months ago (2017-05-03 13:39:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2856963002/20001
3 years, 7 months ago (2017-05-03 13:40:08 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 14:26:30 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e3cfa1285898021bfe5bd4e62ddd...

Powered by Google App Engine
This is Rietveld 408576698