Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2856943002: Revert "Revert of Fix omnibox suggestions being overdrawn with the nav bar. (patchset #1 id:1 of ht… (Closed)

Created:
3 years, 7 months ago by Ted C
Modified:
3 years, 7 months ago
Reviewers:
mdjones
CC:
chromium-reviews, jdonnelly+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Revert of Fix omnibox suggestions being overdrawn with the nav bar. (patchset #1 id:1 of https://codereview.chromium.org/2849283002/ )" This reverts commit 50e675c553115af32441ed00149935ff604fa71e. findViewById(android.R.id.content) can return null if called early enough. BUG=669150 Review-Url: https://codereview.chromium.org/2856943002 Cr-Commit-Position: refs/heads/master@{#469186} Committed: https://chromium.googlesource.com/chromium/src/+/3d7778bec90aef27109d62a3455fd004fd1d7592

Patch Set 1 #

Patch Set 2 : Fix null root view #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/omnibox/SuggestionView.java View 4 chunks +7 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/util/ViewUtils.java View 1 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Ted C
PTAL again This also fixes the cases where the root view is the first child ...
3 years, 7 months ago (2017-05-02 20:52:16 UTC) #3
mdjones
lgtm
3 years, 7 months ago (2017-05-02 21:00:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2856943002/40001
3 years, 7 months ago (2017-05-03 21:03:16 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 23:09:47 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/3d7778bec90aef27109d62a3455f...

Powered by Google App Engine
This is Rietveld 408576698