Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(941)

Issue 2856933004: ChromeOS OOBE: Fix language and keyboard md-select look. (Closed)

Created:
3 years, 7 months ago by dpapad
Modified:
3 years, 7 months ago
Reviewers:
Alexander Alekseev
CC:
achuith+watch_chromium.org, alemate+watch_chromium.org, arv+watch_chromium.org, chromium-reviews, dcheng, oshima+watch_chromium.org, Dan Beam
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

ChromeOS OOBE: Fix language and keyboard md-select look. BUG=716374 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2856933004 Cr-Commit-Position: refs/heads/master@{#468866} Committed: https://chromium.googlesource.com/chromium/src/+/c9acca9df826b31c2b58b50565172428396afb30

Patch Set 1 #

Patch Set 2 : Nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -15 lines) Patch
M chrome/browser/resources/chromeos/login/oobe_i18n_dropdown.css View 1 chunk +1 line, -9 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_i18n_dropdown.html View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_welcome.html View 1 3 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
dpapad
3 years, 7 months ago (2017-05-02 18:22:49 UTC) #7
dpapad
After screenshots at http://imgur.com/a/ShyWe.
3 years, 7 months ago (2017-05-02 18:23:11 UTC) #8
Alexander Alekseev
lgtm
3 years, 7 months ago (2017-05-03 00:36:51 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2856933004/20001
3 years, 7 months ago (2017-05-03 01:14:38 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 01:55:47 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c9acca9df826b31c2b58b5056517...

Powered by Google App Engine
This is Rietveld 408576698