Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(914)

Issue 2856923002: Rejig stability intstrumentation filenames and targets (Closed)

Created:
3 years, 7 months ago by manzagop (departed)
Modified:
3 years, 7 months ago
Reviewers:
rkaplow, rkaplow1, scottmg
CC:
chromium-reviews, asvitkine+watch_chromium.org, bcwhite
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rejig stability intstrumentation filenames and targets The main change is to rename postmortem_report_extractor to stability_report_extractor, and pull it out to a separate target. We want to use this not only postmortem, but also on crash. BUG=620813 Review-Url: https://codereview.chromium.org/2856923002 Cr-Commit-Position: refs/heads/master@{#469438} Committed: https://chromium.googlesource.com/chromium/src/+/309a96117edbe53789c764bfcff76c13b0e88b52

Patch Set 1 #

Patch Set 2 : Merge #

Patch Set 3 : Missing include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -473 lines) Patch
M chrome/browser/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_browser_field_trials_desktop.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/chrome_metrics_service_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/browser_watcher/BUILD.gn View 1 4 chunks +28 lines, -18 lines 0 comments Download
M components/browser_watcher/postmortem_report_collector.h View 1 chunk +1 line, -1 line 0 comments Download
M components/browser_watcher/postmortem_report_collector_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D components/browser_watcher/postmortem_report_extractor.h View 1 chunk +0 lines, -36 lines 0 comments Download
D components/browser_watcher/postmortem_report_extractor.cc View 1 chunk +0 lines, -271 lines 0 comments Download
M components/browser_watcher/stability_debugging.h View 1 chunk +0 lines, -22 lines 0 comments Download
M components/browser_watcher/stability_debugging.cc View 1 chunk +0 lines, -83 lines 0 comments Download
M components/browser_watcher/stability_debugging_win_unittest.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A + components/browser_watcher/stability_paths.h View 2 chunks +4 lines, -11 lines 0 comments Download
A + components/browser_watcher/stability_paths.cc View 3 chunks +6 lines, -20 lines 0 comments Download
A + components/browser_watcher/stability_report_extractor.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/browser_watcher/stability_report_extractor.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/browser_watcher/watcher_metrics_provider_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/metrics/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 49 (38 generated)
manzagop (departed)
Hi Brian, This moves a few things around, nothing added. Could you have a look? ...
3 years, 7 months ago (2017-05-02 19:37:59 UTC) #18
manzagop (departed)
Hi Scott, Could you have a look at this? It's renames a file and rejigs ...
3 years, 7 months ago (2017-05-03 21:46:06 UTC) #27
scottmg
lgtm
3 years, 7 months ago (2017-05-03 21:56:11 UTC) #28
manzagop (departed)
Thanks Scott!
3 years, 7 months ago (2017-05-03 21:58:29 UTC) #30
manzagop (departed)
Hi Rob, Could you have an OWNERS' look at: chrome\browser\chrome_browser_field_trials_desktop.cc chrome\browser\metrics\chrome_metrics_service_client.cc components\metrics\BUILD.gn Thanks! P-A
3 years, 7 months ago (2017-05-03 21:59:26 UTC) #32
manzagop (departed)
Friendly ping. The OWNERS review is pretty small. :)
3 years, 7 months ago (2017-05-04 19:12:56 UTC) #39
rkaplow1
lgtm
3 years, 7 months ago (2017-05-04 19:43:51 UTC) #41
rkaplow
lgtm whoops wrong account
3 years, 7 months ago (2017-05-04 19:44:18 UTC) #42
manzagop (departed)
Thanks!
3 years, 7 months ago (2017-05-04 19:48:19 UTC) #43
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2856923002/120001
3 years, 7 months ago (2017-05-04 19:49:08 UTC) #46
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 19:55:55 UTC) #49
Message was sent while issue was closed.
Committed patchset #3 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/309a96117edbe53789c764bfcff7...

Powered by Google App Engine
This is Rietveld 408576698