Add flags for CrOS Component using Feature API

Add flags for CrOS Component using Feature API

This CL adds flags to enable/disable Chrome OS Component
(go/cros_component).

BUG=chromium:690521
TEST= Chrome OS Compnent shows up in Chrome://flags

Review-Url: https://codereview.chromium.org/2856913005
Cr-Commit-Position: refs/heads/master@{#469266}
Committed: https://chromium.googlesource.com/chromium/src/+/32e9672ac30367da0695e2dce71fdac9deed412e

[xiaochu, 2017-05-02 23:12:23]

Description was changed from

==========
Add flags for CrOS Component using Feature API

This CL adds flags to enable/disable Chrome OS Component
(go/cros_component).

BUG=chromium:690521
TEST= Chrome OS Compnent shows up in Chrome://flags
==========

to

==========
Add flags for CrOS Component using Feature API

This CL adds flags to enable/disable Chrome OS Component
(go/cros_component).

BUG=chromium:690521
TEST= Chrome OS Compnent shows up in Chrome://flags
==========

[xiaochu, 2017-05-02 23:12:24]

xiaochu@chromium.org changed reviewers:
+ adlr@chromium.org, justincarlson@chromium.org, skau@chromium.org

[xiaochu, 2017-05-02 23:35:08]

xiaochu@chromium.org changed reviewers:
+ oshima@chromium.org

[xiaochu, 2017-05-03 20:50:19]

On 2017/05/02 23:35:08, xiaochu wrote:
> mailto:xiaochu@chromium.org changed reviewers:
> + mailto:oshima@chromium.org

Can you please take a look?

[skau, 2017-05-03 21:07:49]

https://codereview.chromium.org/2856913005/diff/20001/chrome/browser/about_fl...
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/2856913005/diff/20001/chrome/browser/about_fl...
chrome/browser/about_flags.cc:2306: {"cros-component",
flag_descriptions::kCrOSComponentName,
You want this to say enable-cros-component so it's easy to tell what the default
state is.

https://codereview.chromium.org/2856913005/diff/20001/chrome/browser/flag_des...
File chrome/browser/flag_descriptions.cc (right):

https://codereview.chromium.org/2856913005/diff/20001/chrome/browser/flag_des...
chrome/browser/flag_descriptions.cc:2327: "Enable the use of Chrome OS
Component.";
Do we want this description to be more verbose?

[xiaochu, 2017-05-03 23:40:29]

thanks!

https://codereview.chromium.org/2856913005/diff/20001/chrome/browser/about_fl...
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/2856913005/diff/20001/chrome/browser/about_fl...
chrome/browser/about_flags.cc:2306: {"cros-component",
flag_descriptions::kCrOSComponentName,
On 2017/05/03 21:07:49, skau wrote:
> You want this to say enable-cros-component so it's easy to tell what the
default
> state is.

Done.

https://codereview.chromium.org/2856913005/diff/20001/chrome/browser/flag_des...
File chrome/browser/flag_descriptions.cc (right):

https://codereview.chromium.org/2856913005/diff/20001/chrome/browser/flag_des...
chrome/browser/flag_descriptions.cc:2327: "Enable the use of Chrome OS
Component.";
On 2017/05/03 21:07:49, skau wrote:
> Do we want this description to be more verbose?

Done.

[skau, 2017-05-03 23:41:38]

lgtm

[xiaochu, 2017-05-03 23:43:31]

The CQ bit was checked by xiaochu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-03 23:44:14]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 23:48:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-03 23:48:25]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[xiaochu, 2017-05-04 00:03:54]

The CQ bit was checked by xiaochu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-04 00:04:37]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 01:09:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-04 01:09:27]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[xiaochu, 2017-05-04 02:28:43]

The CQ bit was checked by xiaochu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-04 02:28:55]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 02:33:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-04 02:33:31]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[xiaochu, 2017-05-04 02:55:54]

The CQ bit was checked by xiaochu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-04 02:56:13]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 02:59:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-04 02:59:43]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[xiaochu, 2017-05-04 03:06:39]

The CQ bit was checked by xiaochu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-04 03:06:55]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 03:10:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-04 03:10:07]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[xiaochu, 2017-05-04 03:22:10]

The CQ bit was checked by xiaochu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-04 03:22:24]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 04:08:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-04 04:08:28]

Dry run: This issue passed the CQ dry run.

[xiaochu, 2017-05-04 04:09:11]

The CQ bit was checked by xiaochu@chromium.org

[xiaochu, 2017-05-04 04:09:12]

The patchset sent to the CQ was uploaded after l-g-t-m from skau@chromium.org
Link to the patchset: https://codereview.chromium.org/2856913005/#ps140001
(title: "rebase")

[commit-bot: I haz the power, 2017-05-04 04:09:27]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 04:15:12]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1493870951897930,
"parent_rev": "3591730780df82f278bcb2143a1ca7403814c805", "commit_rev":
"32e9672ac30367da0695e2dce71fdac9deed412e"}

[commit-bot: I haz the power, 2017-05-04 04:16:15]

Description was changed from

==========
Add flags for CrOS Component using Feature API

This CL adds flags to enable/disable Chrome OS Component
(go/cros_component).

BUG=chromium:690521
TEST= Chrome OS Compnent shows up in Chrome://flags
==========

to

==========
Add flags for CrOS Component using Feature API

This CL adds flags to enable/disable Chrome OS Component
(go/cros_component).

BUG=chromium:690521
TEST= Chrome OS Compnent shows up in Chrome://flags

Review-Url: https://codereview.chromium.org/2856913005
Cr-Commit-Position: refs/heads/master@{#469266}
Committed:
https://chromium.googlesource.com/chromium/src/+/32e9672ac30367da0695e2dce71f...
==========

[commit-bot: I haz the power, 2017-05-04 04:16:16]

Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/32e9672ac30367da0695e2dce71f...