Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2856893004:
predictors: Enable SpeculativeResourcePrefetching for fieldtrial testing. (Closed)
Descriptionpredictors: Enable SpeculativeResourcePrefetching for fieldtrial testing.
BUG=631966
Review-Url: https://codereview.chromium.org/2856893004
Cr-Commit-Position: refs/heads/master@{#469317}
Committed: https://chromium.googlesource.com/chromium/src/+/f89e3e140fa7c28737f493a02e7103ab3946a677
Patch Set 1 #
Total comments: 2
Patch Set 2 : Remove learning experiment. #Messages
Total messages: 20 (11 generated)
alexilin@chromium.org changed reviewers: + jwd@chromium.org
Hi jwd, please review this change! Thanks!
alexilin@chromium.org changed reviewers: + pasko@chromium.org
pasko: Do we need to have perf coverage for the feature?
This may tell us about something actinable, let's try it (should not be blocking the Finch Beta config). I think it's more likely that some browser tests would fail than our perf bots would detect anything. Please send it to trybots. https://codereview.chromium.org/2856893004/diff/1/testing/variations/fieldtri... File testing/variations/fieldtrial_testing_config.json (right): https://codereview.chromium.org/2856893004/diff/1/testing/variations/fieldtri... testing/variations/fieldtrial_testing_config.json:2810: { afair the second experiment is never used, let's keep just one?
The CQ bit was checked by alexilin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2856893004/diff/1/testing/variations/fieldtri... File testing/variations/fieldtrial_testing_config.json (right): https://codereview.chromium.org/2856893004/diff/1/testing/variations/fieldtri... testing/variations/fieldtrial_testing_config.json:2810: { On 2017/05/03 16:47:29, pasko wrote: > afair the second experiment is never used, let's keep just one? You are right. I've added it rather for documentation purposes. Done.
lgtm
The CQ bit was checked by alexilin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by alexilin@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493903094166900,
"parent_rev": "59c10fe1fa4658261ac1ef92176e7f558a7c3687", "commit_rev":
"f89e3e140fa7c28737f493a02e7103ab3946a677"}
Message was sent while issue was closed.
Description was changed from ========== predictors: Enable SpeculativeResourcePrefetching for fieldtrial testing. BUG=631966 ========== to ========== predictors: Enable SpeculativeResourcePrefetching for fieldtrial testing. BUG=631966 Review-Url: https://codereview.chromium.org/2856893004 Cr-Commit-Position: refs/heads/master@{#469317} Committed: https://chromium.googlesource.com/chromium/src/+/f89e3e140fa7c28737f493a02e71... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/f89e3e140fa7c28737f493a02e71...
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2872303004/ by alexilin@chromium.org. The reason for reverting is: SpeculativePrefetching causes regressions for those tests that are forced to load all resources from the network. (http://crbug.com/718910). |
