Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 2856863010: MD Settings: Network: Check managed properties for known networks menu (Closed)

Created:
3 years, 7 months ago by stevenjb
Modified:
3 years, 7 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-settings_chromium.org, dbeam+watch-closure_chromium.org, stevenjb+watch-md-settings_chromium.org, jlklein+watch-closure_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Network: Check managed properties for known networks menu BUG=716688 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2856863010 Cr-Commit-Position: refs/heads/master@{#470112} Committed: https://chromium.googlesource.com/chromium/src/+/05107588c7a7133f4af22a9337b9ef266e692d63

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -7 lines) Patch
M chrome/browser/resources/settings/internet_page/compiled_resources2.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/internet_known_networks_page.html View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/internet_known_networks_page.js View 1 3 chunks +23 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
stevenjb
3 years, 7 months ago (2017-05-04 22:44:45 UTC) #3
michaelpg
lgtm
3 years, 7 months ago (2017-05-05 19:39:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2856863010/20001
3 years, 7 months ago (2017-05-08 17:23:18 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-08 20:39:35 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/05107588c7a7133f4af22a9337b9...

Powered by Google App Engine
This is Rietveld 408576698