Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2856863005: Rename SVGPreserveAspectRatio::GetCTM to ComputeTransform (Closed)

Created:
3 years, 7 months ago by fs
Modified:
3 years, 7 months ago
Reviewers:
Stephen Chennney
CC:
fs, blink-reviews, chromium-reviews, krit, fmalita+watch_chromium.org, gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename SVGPreserveAspectRatio::GetCTM to ComputeTransform This method doesn't "get (a) CTM", it rather computes a transform that maps from the (initial) viewport space to the viewbox space while considering the value of 'preserveAspectRatio'. Review-Url: https://codereview.chromium.org/2856863005 Cr-Commit-Position: refs/heads/master@{#469057} Committed: https://chromium.googlesource.com/chromium/src/+/ddffea091f64d790fa6b2f40a82e19b39b1768c9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -13 lines) Patch
M third_party/WebKit/Source/core/svg/SVGFitToViewBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPreserveAspectRatio.h View 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPreserveAspectRatio.cpp View 1 chunk +7 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
fs
3 years, 7 months ago (2017-05-03 15:23:13 UTC) #4
Stephen Chennney
lgtm. Big fan of sensible naming.
3 years, 7 months ago (2017-05-03 18:33:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2856863005/1
3 years, 7 months ago (2017-05-03 18:48:55 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 18:57:30 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ddffea091f64d790fa6b2f40a82e...

Powered by Google App Engine
This is Rietveld 408576698