Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Issue 2856773003: Remove deprecated ExecutionContextTask (Closed)

Created:
3 years, 7 months ago by yuryu
Modified:
3 years, 6 months ago
Reviewers:
haraken, kinuko, nhiroki, tzik
CC:
chromium-reviews, kinuko+worker_chromium.org, sof, eae+blinkwatch, shimazu+worker_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, blink-worker-reviews_chromium.org, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove deprecated ExecutionContextTask ExecutionContextTask has been deprecated and replaced with WTF::Closure. This patch removes the class and related methods, including ExecutionContext::postTask and overridden methods. BUG=625927 Review-Url: https://codereview.chromium.org/2856773003 Cr-Commit-Position: refs/heads/master@{#477222} Committed: https://chromium.googlesource.com/chromium/src/+/ae0b9e7f0d6fe6642fd504557d3780656fc49cd3

Patch Set 1 #

Total comments: 2

Patch Set 2 : restore private / rebase #

Messages

Total messages: 31 (19 generated)
yuryu
ptal, thanks.
3 years, 7 months ago (2017-05-02 06:28:34 UTC) #4
tzik
lgtm
3 years, 7 months ago (2017-05-08 04:04:25 UTC) #7
nhiroki
LGTM with a minor comment Can you land this after issue 714874 is resolved? The ...
3 years, 7 months ago (2017-05-08 04:28:42 UTC) #8
nhiroki
On 2017/05/08 04:28:42, nhiroki (slow) wrote: > Can you land this after issue 714874 is ...
3 years, 6 months ago (2017-05-29 03:46:31 UTC) #9
yuryu
https://codereview.chromium.org/2856773003/diff/1/third_party/WebKit/Source/core/workers/WorkerOrWorkletGlobalScope.h File third_party/WebKit/Source/core/workers/WorkerOrWorkletGlobalScope.h (left): https://codereview.chromium.org/2856773003/diff/1/third_party/WebKit/Source/core/workers/WorkerOrWorkletGlobalScope.h#oldcode58 third_party/WebKit/Source/core/workers/WorkerOrWorkletGlobalScope.h:58: private: On 2017/05/08 04:28:42, nhiroki wrote: > "private" is ...
3 years, 6 months ago (2017-06-06 02:55:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2856773003/20001
3 years, 6 months ago (2017-06-06 04:56:03 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/456344)
3 years, 6 months ago (2017-06-06 05:03:49 UTC) #19
yuryu
ptal, thanks.
3 years, 6 months ago (2017-06-06 05:10:13 UTC) #22
haraken
LGTM, this is awesome!
3 years, 6 months ago (2017-06-06 06:05:58 UTC) #23
kinuko
+1
3 years, 6 months ago (2017-06-06 06:15:59 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2856773003/20001
3 years, 6 months ago (2017-06-06 06:59:32 UTC) #26
commit-bot: I haz the power
3 years, 6 months ago (2017-06-06 07:04:30 UTC) #29
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ae0b9e7f0d6fe6642fd504557d37...

Powered by Google App Engine
This is Rietveld 408576698