Clean up bindings/core/v8 (Part 4)

Clean up bindings/core/v8 (Part 4)

This CL removes the following files from bindings/core/v8 and updates
all include sites to use their platform/bindings version:

- V8DOMWrapper.h
- V8GlobalValueMap.h
- V8ObjectConstructor.h
- V0CustomElementBinding.h
- V8Binding.h
- V8BindingMacros.h

BUG=682322
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2856743002
Cr-Commit-Position: refs/heads/master@{#469354}
Committed: https://chromium.googlesource.com/chromium/src/+/9bb812ab8655ff4ab45391b6e35f8df1a4816a01

[adithyas, 2017-05-01 21:48:07]

Description was changed from

==========
Clean up bindings/core/v8 (Part 4)

This CL removes the following files from bindings/core/v8 and updates
all include sites to use their platform/bindings version:

- V8DOMWrapper.h
- V8GlobalValueMap.h
- V8ObjectConstructor.h
- V0CustomElementBinding.h
- V8Binding.h
- V8BindingMacros.h

BUG=682322
==========

to

==========
Clean up bindings/core/v8 (Part 4)

This CL removes the following files from bindings/core/v8 and updates
all include sites to use their platform/bindings version:

- V8DOMWrapper.h
- V8GlobalValueMap.h
- V8ObjectConstructor.h
- V0CustomElementBinding.h
- V8Binding.h
- V8BindingMacros.h

BUG=682322
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[adithyas, 2017-05-01 21:49:36]

The CQ bit was checked by adithyas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-01 21:50:20]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 00:39:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-02 00:39:29]

Dry run: This issue passed the CQ dry run.

[adithyas, 2017-05-03 20:15:26]

adithyas@chromium.org changed reviewers:
+ haraken@chromium.org, jbroman@chromium.org

[haraken, 2017-05-04 02:07:52]

LGTM

I should have mentioned this earlier but I think that V0CustomElementBinding.h
should be kept in core/ because it's part of the custom element implementation
(i.e., part of the DOM spec).

[adithyas, 2017-05-04 14:34:42]

On 2017/05/04 at 02:07:52, haraken wrote:
> LGTM
> 
> I should have mentioned this earlier but I think that V0CustomElementBinding.h
should be kept in core/ because it's part of the custom element implementation
(i.e., part of the DOM spec).

It looked like the class was an abstraction used to hold custom elements in
V8PerContextData, so I thought it would be ok just to move that one file. Most
of the implementation of custom elements is still in bindings/core.

[haraken, 2017-05-04 14:38:00]

On 2017/05/04 14:34:42, adithyas wrote:
> On 2017/05/04 at 02:07:52, haraken wrote:
> > LGTM
> > 
> > I should have mentioned this earlier but I think that
V0CustomElementBinding.h
> should be kept in core/ because it's part of the custom element implementation
> (i.e., part of the DOM spec).
> 
> It looked like the class was an abstraction used to hold custom elements in
> V8PerContextData, so I thought it would be ok just to move that one file. Most
> of the implementation of custom elements is still in bindings/core.

Ah, that makes sense. You're right :)

[adithyas, 2017-05-04 14:49:46]

The CQ bit was checked by adithyas@chromium.org

[adithyas, 2017-05-04 14:49:47]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2856743002/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2017-05-04 14:50:03]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 16:36:35]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493909386884940,
"parent_rev": "35bdb0b1aa17566fbdbc83d4dffa6ef4946c2281", "commit_rev":
"9bb812ab8655ff4ab45391b6e35f8df1a4816a01"}

[commit-bot: I haz the power, 2017-05-04 16:36:46]

Description was changed from

==========
Clean up bindings/core/v8 (Part 4)

This CL removes the following files from bindings/core/v8 and updates
all include sites to use their platform/bindings version:

- V8DOMWrapper.h
- V8GlobalValueMap.h
- V8ObjectConstructor.h
- V0CustomElementBinding.h
- V8Binding.h
- V8BindingMacros.h

BUG=682322
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Clean up bindings/core/v8 (Part 4)

This CL removes the following files from bindings/core/v8 and updates
all include sites to use their platform/bindings version:

- V8DOMWrapper.h
- V8GlobalValueMap.h
- V8ObjectConstructor.h
- V0CustomElementBinding.h
- V8Binding.h
- V8BindingMacros.h

BUG=682322
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2856743002
Cr-Commit-Position: refs/heads/master@{#469354}
Committed:
https://chromium.googlesource.com/chromium/src/+/9bb812ab8655ff4ab45391b6e35f...
==========

[commit-bot: I haz the power, 2017-05-04 16:36:47]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9bb812ab8655ff4ab45391b6e35f...