Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Issue 2856693002: Cronet iOS: Delete CRNPauseableHTTPProtocolHandler (Closed)

Created:
3 years, 7 months ago by kapishnikov
Modified:
3 years, 7 months ago
Reviewers:
Elly Fong-Jones, mef
CC:
chromium-reviews, cbentzel+watch_chromium.org, ios-reviews_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Cronet iOS: Delete CRNPauseableHTTPProtocolHandler BUG=711783 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2856693002 Cr-Commit-Position: refs/heads/master@{#468639} Committed: https://chromium.googlesource.com/chromium/src/+/4d000d1bfbbf3965f8c13f968fb6847a9c27c221

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -89 lines) Patch
M components/cronet/ios/Cronet.mm View 2 chunks +3 lines, -3 lines 0 comments Download
M ios/crnet/crnet_environment.mm View 2 chunks +3 lines, -3 lines 0 comments Download
M ios/net/crn_http_protocol_handler.h View 1 chunk +0 lines, -9 lines 0 comments Download
M ios/net/crn_http_protocol_handler.mm View 1 chunk +0 lines, -74 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
kapishnikov
3 years, 7 months ago (2017-05-01 21:09:27 UTC) #3
mef
lgtm, adding Elly as ios/net OWNER.
3 years, 7 months ago (2017-05-01 21:18:35 UTC) #5
Elly Fong-Jones
ios/net lgtm
3 years, 7 months ago (2017-05-02 13:50:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2856693002/1
3 years, 7 months ago (2017-05-02 14:29:21 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 15:13:11 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4d000d1bfbbf3965f8c13f968fb6...

Powered by Google App Engine
This is Rietveld 408576698