Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Unified Diff: content/browser/frame_host/navigation_handle_impl.cc

Issue 2856653004: Require a process ID when looking up RFHs by FrameTreeNode ID. (Closed)
Patch Set: Simplify ExtNavThrottle Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigation_handle_impl.cc
diff --git a/content/browser/frame_host/navigation_handle_impl.cc b/content/browser/frame_host/navigation_handle_impl.cc
index 37f1c0c581746f799c9578ace7b1a76f98236dcb..c4524a8a7c3e821dcff3c9d33ec625071afdc5bc 100644
--- a/content/browser/frame_host/navigation_handle_impl.cc
+++ b/content/browser/frame_host/navigation_handle_impl.cc
@@ -230,11 +230,11 @@ int NavigationHandleImpl::GetFrameTreeNodeId() {
return frame_tree_node_->frame_tree_node_id();
}
-int NavigationHandleImpl::GetParentFrameTreeNodeId() {
+RenderFrameHostImpl* NavigationHandleImpl::GetParentFrame() {
if (frame_tree_node_->IsMainFrame())
- return FrameTreeNode::kFrameTreeNodeInvalidId;
+ return nullptr;
- return frame_tree_node_->parent()->frame_tree_node_id();
+ return frame_tree_node_->parent()->current_frame_host();
}
const base::TimeTicks& NavigationHandleImpl::NavigationStart() {

Powered by Google App Engine
This is Rietveld 408576698