Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Side by Side Diff: content/browser/frame_host/navigation_handle_impl.cc

Issue 2856653004: Require a process ID when looking up RFHs by FrameTreeNode ID. (Closed)
Patch Set: Simplify ExtNavThrottle Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/frame_host/navigation_handle_impl.h" 5 #include "content/browser/frame_host/navigation_handle_impl.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "content/browser/appcache/appcache_navigation_handle.h" 10 #include "content/browser/appcache/appcache_navigation_handle.h"
(...skipping 212 matching lines...) Expand 10 before | Expand all | Expand 10 after
223 } 223 }
224 224
225 const std::vector<GURL>& NavigationHandleImpl::GetRedirectChain() { 225 const std::vector<GURL>& NavigationHandleImpl::GetRedirectChain() {
226 return redirect_chain_; 226 return redirect_chain_;
227 } 227 }
228 228
229 int NavigationHandleImpl::GetFrameTreeNodeId() { 229 int NavigationHandleImpl::GetFrameTreeNodeId() {
230 return frame_tree_node_->frame_tree_node_id(); 230 return frame_tree_node_->frame_tree_node_id();
231 } 231 }
232 232
233 int NavigationHandleImpl::GetParentFrameTreeNodeId() { 233 RenderFrameHostImpl* NavigationHandleImpl::GetParentFrame() {
234 if (frame_tree_node_->IsMainFrame()) 234 if (frame_tree_node_->IsMainFrame())
235 return FrameTreeNode::kFrameTreeNodeInvalidId; 235 return nullptr;
236 236
237 return frame_tree_node_->parent()->frame_tree_node_id(); 237 return frame_tree_node_->parent()->current_frame_host();
238 } 238 }
239 239
240 const base::TimeTicks& NavigationHandleImpl::NavigationStart() { 240 const base::TimeTicks& NavigationHandleImpl::NavigationStart() {
241 return navigation_start_; 241 return navigation_start_;
242 } 242 }
243 243
244 bool NavigationHandleImpl::IsPost() { 244 bool NavigationHandleImpl::IsPost() {
245 CHECK_NE(INITIAL, state_) 245 CHECK_NE(INITIAL, state_)
246 << "This accessor should not be called before the request is started."; 246 << "This accessor should not be called before the request is started.";
247 return method_ == "POST"; 247 return method_ == "POST";
(...skipping 799 matching lines...) Expand 10 before | Expand all | Expand 10 after
1047 if (node->current_url().EqualsIgnoringRef(url_)) { 1047 if (node->current_url().EqualsIgnoringRef(url_)) {
1048 if (found_self_reference) 1048 if (found_self_reference)
1049 return true; 1049 return true;
1050 found_self_reference = true; 1050 found_self_reference = true;
1051 } 1051 }
1052 } 1052 }
1053 return false; 1053 return false;
1054 } 1054 }
1055 1055
1056 } // namespace content 1056 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698