Clean up bindings/core/v8 (Part 3)

Clean up bindings/core/v8 (Part 3)

This CL removes the following files from bindings/core/v8 and updates
all include sites to use their platform/bindings version:

- ToV8.h
- TraceWrapperMember.h
- TraceWrapperV8Reference.h
- ScriptWrappableVisitorVerifier.h
- SharedPersistent.h
- StringResource.h
- ScriptWrappableVisitor.h

BUG=682322
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2856653003
Cr-Commit-Position: refs/heads/master@{#469194}
Committed: https://chromium.googlesource.com/chromium/src/+/7e1e52baf53efcc48468f12c996e8b22707da6de

[adithyas, 2017-05-01 20:41:23]

Description was changed from

==========
Clean up bindings/core/v8 (Part 3)

This CL removes the following files from bindings/core/v8 and updates
all include sites to use their platform/bindings version:

- ToV8.h
- TraceWrapperMember.h
- TraceWrapperV8Reference.h
- ScriptWrappableVisitorVerifier.h
- SharedPersistent.h
- StringResource.h
- ScriptWrappableVisitor.h

BUG=682322
==========

to

==========
Clean up bindings/core/v8 (Part 3)

This CL removes the following files from bindings/core/v8 and updates
all include sites to use their platform/bindings version:

- ToV8.h
- TraceWrapperMember.h
- TraceWrapperV8Reference.h
- ScriptWrappableVisitorVerifier.h
- SharedPersistent.h
- StringResource.h
- ScriptWrappableVisitor.h

BUG=682322
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[adithyas, 2017-05-01 20:42:44]

The CQ bit was checked by adithyas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-01 20:43:40]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[adithyas, 2017-05-01 21:46:24]

adithyas@chromium.org changed reviewers:
+ haraken@chromium.org, jbroman@chromium.org

[jbroman, 2017-05-01 21:58:40]

rs lgtm

https://codereview.chromium.org/2856653003/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorTest.cpp
(right):

https://codereview.chromium.org/2856653003/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorTest.cpp:5:
#include "platform/bindings/ScriptWrappableVisitor.h"
Ideally this test would move alongside the file it tests, but I realize that
V8GCController makes it not entirely trivial to do so. (Really, that class does
two separate things: implement the GC prologue/epilogue and allow forced GC.
Separating those out seems like it would do the trick.)

[commit-bot: I haz the power, 2017-05-01 23:26:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-01 23:26:47]

Dry run: This issue passed the CQ dry run.

[haraken, 2017-05-01 23:48:44]

LGTM

[adithyas, 2017-05-03 20:14:35]

https://codereview.chromium.org/2856653003/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorTest.cpp
(right):

https://codereview.chromium.org/2856653003/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorTest.cpp:5:
#include "platform/bindings/ScriptWrappableVisitor.h"
On 2017/05/01 at 21:58:39, jbroman wrote:
> Ideally this test would move alongside the file it tests, but I realize that
V8GCController makes it not entirely trivial to do so. (Really, that class does
two separate things: implement the GC prologue/epilogue and allow forced GC.
Separating those out seems like it would do the trick.)

Yeah agreed, I'm going to try moving some of the test files related to the
classes that moved in later CLs.

[adithyas, 2017-05-03 20:14:49]

The CQ bit was checked by adithyas@chromium.org

[adithyas, 2017-05-03 20:14:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, jbroman@chromium.org
Link to the patchset: https://codereview.chromium.org/2856653003/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2017-05-03 20:15:18]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 23:22:55]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493842489507300,
"parent_rev": "2a542d8debc1075277dfa8de50dea36fb96d5aff", "commit_rev":
"7e1e52baf53efcc48468f12c996e8b22707da6de"}

[commit-bot: I haz the power, 2017-05-03 23:23:08]

Description was changed from

==========
Clean up bindings/core/v8 (Part 3)

This CL removes the following files from bindings/core/v8 and updates
all include sites to use their platform/bindings version:

- ToV8.h
- TraceWrapperMember.h
- TraceWrapperV8Reference.h
- ScriptWrappableVisitorVerifier.h
- SharedPersistent.h
- StringResource.h
- ScriptWrappableVisitor.h

BUG=682322
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Clean up bindings/core/v8 (Part 3)

This CL removes the following files from bindings/core/v8 and updates
all include sites to use their platform/bindings version:

- ToV8.h
- TraceWrapperMember.h
- TraceWrapperV8Reference.h
- ScriptWrappableVisitorVerifier.h
- SharedPersistent.h
- StringResource.h
- ScriptWrappableVisitor.h

BUG=682322
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2856653003
Cr-Commit-Position: refs/heads/master@{#469194}
Committed:
https://chromium.googlesource.com/chromium/src/+/7e1e52baf53efcc48468f12c996e...
==========

[commit-bot: I haz the power, 2017-05-03 23:23:10]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7e1e52baf53efcc48468f12c996e...