Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 2856653002: Roll Lighthouse & add error reporting (Closed)

Created:
3 years, 7 months ago by paulirish
Modified:
3 years, 7 months ago
Reviewers:
pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll Lighthouse & add error reporting BUG=663085 Review-Url: https://codereview.chromium.org/2856653002 Cr-Commit-Position: refs/heads/master@{#468468} Committed: https://chromium.googlesource.com/chromium/src/+/ba1c3ee93552cd8532529c2aa878471b2348b5af

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1465 lines, -480 lines) Patch
M third_party/WebKit/Source/devtools/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js View 5 chunks +60 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/audits2/audits2Panel.css View 1 chunk +11 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/renderer/category-renderer.js View 6 chunks +78 lines, -147 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/renderer/details-renderer.js View 4 chunks +20 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/renderer/dom.js View 5 chunks +54 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/renderer/report-renderer.js View 4 chunks +101 lines, -142 lines 0 comments Download
A third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/renderer/util.js View 1 chunk +78 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/report-styles.css View 7 chunks +145 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/templates.html View 1 chunk +396 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/audits2/module.json View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/audits2_worker/lighthouse/lighthouse-background.js View 76 chunks +517 lines, -128 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
paulirish
Latest Lighthouse is rolled. Added basic error reporting. PTAL
3 years, 7 months ago (2017-05-01 19:04:57 UTC) #2
pfeldman
lgtm
3 years, 7 months ago (2017-05-01 20:27:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2856653002/1
3 years, 7 months ago (2017-05-01 20:29:48 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-01 22:54:49 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ba1c3ee93552cd8532529c2aa878...

Powered by Google App Engine
This is Rietveld 408576698