Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: media/blink/webmediaplayer_impl.h

Issue 2856643002: Explicitly represent "no surface ID yet" in WMPI. (Closed)
Patch Set: removed redundant check Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/blink/webmediaplayer_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/blink/webmediaplayer_impl.h
diff --git a/media/blink/webmediaplayer_impl.h b/media/blink/webmediaplayer_impl.h
index d154f00c4988a4ecc4342a1be3f1e9351991141d..2279b345bc2567ab7e0ec359d3c733cd320a1d63 100644
--- a/media/blink/webmediaplayer_impl.h
+++ b/media/blink/webmediaplayer_impl.h
@@ -626,9 +626,10 @@ class MEDIA_BLINK_EXPORT WebMediaPlayerImpl
// For canceling ongoing surface creation requests when exiting fullscreen.
base::CancelableCallback<void(int)> surface_created_cb_;
- // The current overlay surface id. Populated while in fullscreen once the
- // surface is created.
- int overlay_surface_id_;
+ // The current overlay surface id. Populated, possibly with kNoSurfaceID if
+ // we're not supposed to use an overlay, unless we have an outstanding surface
+ // request to the SurfaceManager.
+ base::Optional<int> overlay_surface_id_;
// If a surface is requested before it's finished being created, the request
// is saved and satisfied once the surface is available. If the decoder does
« no previous file with comments | « no previous file | media/blink/webmediaplayer_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698