Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Side by Side Diff: media/blink/webmediaplayer_impl.h

Issue 2856643002: Explicitly represent "no surface ID yet" in WMPI. (Closed)
Patch Set: removed redundant check Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | media/blink/webmediaplayer_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MEDIA_BLINK_WEBMEDIAPLAYER_IMPL_H_ 5 #ifndef MEDIA_BLINK_WEBMEDIAPLAYER_IMPL_H_
6 #define MEDIA_BLINK_WEBMEDIAPLAYER_IMPL_H_ 6 #define MEDIA_BLINK_WEBMEDIAPLAYER_IMPL_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <memory> 10 #include <memory>
(...skipping 608 matching lines...) Expand 10 before | Expand all | Expand 10 after
619 619
620 std::unique_ptr<RendererFactory> renderer_factory_; 620 std::unique_ptr<RendererFactory> renderer_factory_;
621 621
622 // For requesting surfaces on behalf of the Android H/W decoder in fullscreen. 622 // For requesting surfaces on behalf of the Android H/W decoder in fullscreen.
623 // This will be null everywhere but Android. 623 // This will be null everywhere but Android.
624 SurfaceManager* surface_manager_; 624 SurfaceManager* surface_manager_;
625 625
626 // For canceling ongoing surface creation requests when exiting fullscreen. 626 // For canceling ongoing surface creation requests when exiting fullscreen.
627 base::CancelableCallback<void(int)> surface_created_cb_; 627 base::CancelableCallback<void(int)> surface_created_cb_;
628 628
629 // The current overlay surface id. Populated while in fullscreen once the 629 // The current overlay surface id. Populated, possibly with kNoSurfaceID if
630 // surface is created. 630 // we're not supposed to use an overlay, unless we have an outstanding surface
631 int overlay_surface_id_; 631 // request to the SurfaceManager.
632 base::Optional<int> overlay_surface_id_;
632 633
633 // If a surface is requested before it's finished being created, the request 634 // If a surface is requested before it's finished being created, the request
634 // is saved and satisfied once the surface is available. If the decoder does 635 // is saved and satisfied once the surface is available. If the decoder does
635 // not require restart to change surfaces, this is callback is kept until 636 // not require restart to change surfaces, this is callback is kept until
636 // cleared by the decoder. 637 // cleared by the decoder.
637 SurfaceCreatedCB set_surface_cb_; 638 SurfaceCreatedCB set_surface_cb_;
638 639
639 // On Android an overlay surface means using 640 // On Android an overlay surface means using
640 // SurfaceView instead of SurfaceTexture. 641 // SurfaceView instead of SurfaceTexture.
641 642
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
724 base::CancelableCallback<void(base::TimeTicks)> frame_time_report_cb_; 725 base::CancelableCallback<void(base::TimeTicks)> frame_time_report_cb_;
725 726
726 bool initial_video_height_recorded_ = false; 727 bool initial_video_height_recorded_ = false;
727 728
728 DISALLOW_COPY_AND_ASSIGN(WebMediaPlayerImpl); 729 DISALLOW_COPY_AND_ASSIGN(WebMediaPlayerImpl);
729 }; 730 };
730 731
731 } // namespace media 732 } // namespace media
732 733
733 #endif // MEDIA_BLINK_WEBMEDIAPLAYER_IMPL_H_ 734 #endif // MEDIA_BLINK_WEBMEDIAPLAYER_IMPL_H_
OLDNEW
« no previous file with comments | « no previous file | media/blink/webmediaplayer_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698