Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 2856633002: Adding defensive CHECKs for AudioDecoderConfig crash (Closed)

Created:
3 years, 7 months ago by chcunningham
Modified:
3 years, 7 months ago
Reviewers:
wolenetz
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding defensive CHECKs for AudioDecoderConfig crash Top frames of the crash stack don't make much sense. Checking the obvious sources of memory access issues. BUG=715761 Review-Url: https://codereview.chromium.org/2856633002 Cr-Commit-Position: refs/heads/master@{#468435} Committed: https://chromium.googlesource.com/chromium/src/+/23a93bfe289a0f97e33cbe6dc44a9e72bce8453b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M media/filters/chunk_demuxer.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M media/filters/source_buffer_stream.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
chcunningham
3 years, 7 months ago (2017-05-01 18:46:11 UTC) #2
wolenetz
lgtm % typo in cl descr ("crash")
3 years, 7 months ago (2017-05-01 19:24:27 UTC) #3
chcunningham
thanks
3 years, 7 months ago (2017-05-01 19:41:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2856633002/1
3 years, 7 months ago (2017-05-01 19:41:53 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-05-01 21:54:59 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/23a93bfe289a0f97e33cbe6dc44a...

Powered by Google App Engine
This is Rietveld 408576698